Changeset 40330

Timestamp:

03/24/2017 10:02:02 PM (10 years ago)

Author:

westonruter

Message:

Customize: Improve i18n for strings in hidden widget area notices.

Amends [40312].
Props westonruter, ocean90, swissspidy, SergeyBiryukov, michelleweber for copywriting.
See #33567, #33052.
Fixes #39087.

Location:

trunk

Files:

• src/wp-admin/js/customize-widgets.js (modified) (2 diffs)
• src/wp-includes/class-wp-customize-widgets.php (modified) (2 diffs)
• tests/qunit/fixtures/customize-widgets.js (modified) (2 diffs)

trunk/src/wp-admin/js/customize-widgets.js

@@ -1617 +1617 @@
                                  */
                                 updateNotice = function() {
-                                        var activeSectionCount = getActiveSectionCount(), message, nonRenderedAreaCount, registeredAreaCount;
+                                        var activeSectionCount = getActiveSectionCount(), someRenderedMessage, nonRenderedAreaCount, registeredAreaCount;
                                         noticeContainer.empty();
 
@@ -1625 +1625 @@
                                                 if ( 0 !== activeSectionCount ) {
                                                         nonRenderedAreaCount = registeredAreaCount - activeSectionCount;
-                                                        message = ( 1 === nonRenderedAreaCount ? l10n.someAreasShown.singular : l10n.someAreasShown.plural ).replace( '%d', nonRenderedAreaCount );
+                                                        someRenderedMessage = l10n.someAreasShown[ nonRenderedAreaCount ];
                                                 } else {
-                                                        message = ( 1 === registeredAreaCount ? l10n.noAreasShown.singular : l10n.noAreasShown.plural ).replace( '%d', registeredAreaCount );
+                                                        someRenderedMessage = l10n.noAreasShown;
                                                 }
-
-                                                noticeContainer.append( $( '<p></p>', {
-                                                        text: message
-                                                } ) );
+                                                if ( someRenderedMessage ) {
+                                                        noticeContainer.append( $( '<p></p>', {
+                                                                text: someRenderedMessage
+                                                        } ) );
+                                                }
+
                                                 noticeContainer.append( $( '<p></p>', {
                                                         text: l10n.navigatePreview

trunk/src/wp-includes/class-wp-customize-widgets.php

@@ -721 +721 @@
                 );
 
+                /*
+                 * Gather all strings in PHP that may be needed by JS on the client.
+                 * Once JS i18n is implemented (in #20491), this can be removed.
+                 */
+                $some_non_rendered_areas_messages = array();
+                $some_non_rendered_areas_messages[1] = html_entity_decode(
+                        /* translators: placeholder is the number of other widget areas registered but not rendered */
+                        __( 'Your theme has 1 other widget area, but this particular page doesn’t display it.' ),
+                        ENT_QUOTES,
+                        get_bloginfo( 'charset' )
+                );
+                $registered_sidebar_count = count( $wp_registered_sidebars );
+                for ( $non_rendered_count = 2; $non_rendered_count < $registered_sidebar_count; $non_rendered_count++ ) {
+                        $some_non_rendered_areas_messages[ $non_rendered_count ] = html_entity_decode( sprintf(
+                                /* translators: placeholder is the number of other widget areas registered but not rendered */
+                                _n(
+                                        'Your theme has %s other widget area, but this particular page doesn&#8217;t display it.',
+                                        'Your theme has %s other widget areas, but this particular page doesn&#8217;t display them.',
+                                        $non_rendered_count
+                                ),
+                                number_format_i18n( $non_rendered_count )
+                        ), ENT_QUOTES, get_bloginfo( 'charset' ) );
+                }
+
+                if ( 1 === $registered_sidebar_count ) {
+                        $no_areas_shown_message = html_entity_decode( sprintf(
+                                /* translators: placeholder is the total number of widget areas registered */
+                                __( 'Your theme has 1 widget area, but this particular page doesn&#8217;t display it.' )
+                        ), ENT_QUOTES, get_bloginfo( 'charset' ) );
+                } else {
+                        $no_areas_shown_message = html_entity_decode( sprintf(
+                                /* translators: placeholder is the total number of widget areas registered */
+                                _n(
+                                        'Your theme has %s widget area, but this particular page doesn&#8217;t display it.',
+                                        'Your theme has %s widget areas, but this particular page doesn&#8217;t display them.',
+                                        $registered_sidebar_count
+                                ),
+                                number_format_i18n( $registered_sidebar_count )
+                        ), ENT_QUOTES, get_bloginfo( 'charset' ) );
+                }
+
                 $settings = array(
                         'registeredSidebars'   => array_values( $wp_registered_sidebars ),
@@ -734 +775 @@
                                 'widgetMovedDown'  => __( 'Widget moved down' ),
                                 'navigatePreview'  => __( 'You can navigate to other pages on your site while using the Customizer to view and edit the widgets displayed on those pages.' ),
-                                'someAreasShown'   => wp_array_slice_assoc(
-                                        /* translators: placeholder is the number of other widget areas registered */
-                                        _n_noop(
-                                                'Your theme has %d other widget area, but this particular page doesn\'t display it.',
-                                                'Your theme has %d other widget areas, but this particular page doesn\'t display them.'
-                                        ),
-                                        array( 'singular', 'plural' )
-                                ),
-                                'noAreasShown'    => wp_array_slice_assoc(
-                                        /* translators: placeholder is the total number of widget areas registered */
-                                        _n_noop(
-                                                'Your theme has %d widget area, but this particular page doesn\'t display it.',
-                                                'Your theme has %d widget areas, but this particular page doesn\'t display them.'
-                                        ),
-                                        array( 'singular', 'plural' )
-                                ),
+                                'someAreasShown'   => $some_non_rendered_areas_messages,
+                                'noAreasShown'     => $no_areas_shown_message,
                                 'reorderModeOn'    => __( 'Reorder mode enabled' ),
                                 'reorderModeOff'   => __( 'Reorder mode closed' ),

trunk/tests/qunit/fixtures/customize-widgets.js

@@ -49 +49 @@
                 'error': 'An error has occurred. Please reload the page and try again.',
                 'navigatePreview': 'You can navigate to other pages on your site while using the Customizer to view and edit the widgets displayed on those pages.',
-                'noAreasShown': {
-                        'plural': 'Your theme has %d widget areas, but this particular page doesn\'t display them.',
-                        'singular': 'Your theme has %d widget area, but this particular page doesn\'t display it.'
-                },
+                'noAreasShown': 'Your theme has 3 widget areas, but this particular page doesn\u2019t display them.',
                 'noWidgetsFound': 'No widgets found.',
                 'removeBtnLabel': 'Remove',
@@ -62 +59 @@
                 'saveBtnTooltip': 'Save and preview changes before publishing them.',
                 'someAreasShown': {
-                        'plural': 'Your theme has %d other widget areas, but this particular page doesn\'t display them.',
-                        'singular': 'Your theme has %d other widget area, but this particular page doesn\'t display it.'
+                        '1': 'Your theme has 1 other widget area, but this particular page doesn\u2019t display it.',
+                        '2': 'Your theme has 2 other widget areas, but this particular page doesn\u2019t display them.'
                 },
                 'widgetMovedDown': 'Widget moved down',