Changeset 40338 for branches/4.7

Timestamp:

03/27/2017 09:28:36 AM (7 years ago)

Author:

swissspidy

Message:

Customize: Trailingslash the home nav menu item URL in starter content.

This prevents an additional 301 redirect when clicking on the nav menu item, and it also prevents a scenario where the auth cookie may not be passed
and cause an authentication error when navigating in the customizer.

Props dlh, swissspidy.
Fixes #40112.

Merges [40300] to the 4.7 branch.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/theme.php (modified) (1 diff)
• tests/phpunit/tests/customize/manager.php (modified) (1 diff)

branches/4.7/src/wp-includes/theme.php

@@ -1984 +1984 @@
                 'type' => 'custom',
                 'title' => _x( 'Home', 'Theme starter content' ),
-                'url' => home_url(),
+                'url' => home_url( '/' ),
             ),
             'page_home' => array( // Deprecated in favor of home_link.

branches/4.7/tests/phpunit/tests/customize/manager.php

@@ -485 +485 @@
         $this->assertEquals( 0, $changeset_values['nav_menu_item[-1]']['object_id'] );
         $this->assertEquals( 'custom', $changeset_values['nav_menu_item[-1]']['type'] );
-        $this->assertEquals( home_url(), $changeset_values['nav_menu_item[-1]']['url'] );
+        $this->assertEquals( home_url( '/' ), $changeset_values['nav_menu_item[-1]']['url'] );
 
         $this->assertEmpty( $wp_customize->changeset_data() );