Context Navigation

← Previous Change
Next Change →

siteDetails.php

Timestamp:

03/28/2017 02:31:13 AM (9 years ago)

Author:

jeremyfelt

Message:

Multisite: Allow falsy properties to be cached in site-details.

In previous iterations of WP_Site, there was concern that not all properties would be available when storing a site's details in cache. When introduced in [37918], an ms_loaded check was added to address this concern. Any properties that are still false after ms_loaded really are false and can be cached as such.

Props flixos90.
Fixes #40247.

File:

: 1 edited

trunk/tests/phpunit/tests/multisite/siteDetails.php (modified) (1 diff)

Legend:

: Unmodified
: Added
: Removed

trunk/tests/phpunit/tests/multisite/siteDetails.php

-              r40305
+              r40344
                 $this->assertNotFalse( $cached_result );
+        }
+        /**
+         * @ticket 40247
+         */
+        public function test_site_details_cached_including_false_values() {
+                $id = self::factory()->blog->create();
+                $site = get_site( $id );
+                // Trigger retrieving site details (post_count is not set on new sites)
+                $post_count = $site->post_count;
+                $cached_details = wp_cache_get( $site->id, 'site-details' );
+                wpmu_delete_blog( $id, true );
+                wp_update_network_site_counts();
+                $this->assertNotFalse( $cached_details );
+        }
+}

Note: See TracChangeset for help on using the changeset viewer.

Make WordPress Core

Context Navigation

Changeset 40344 for trunk/tests/phpunit/tests/multisite/siteDetails.php

Legend:

trunk/tests/phpunit/tests/multisite/siteDetails.php

Download in other formats: