Changeset 40357 for trunk

Timestamp:

03/31/2017 04:34:52 PM (9 years ago)

Author:

afercia

Message:

Quick/Bulk Edit: Fix the Tag suggestions position on the Bulk Edit textarea.

Always passes the complete position object to the jQuery autocomplete widget.
Also checks if an autocomplete instance already exists on the Bulk Edit textarea.

Props davidbenton.
Fixes #40242.

Location:

trunk/src/wp-admin/js

Files:

• inline-edit-post.js (modified) (1 diff)
• tags-suggest.js (modified) (1 diff)

trunk/src/wp-admin/js/inline-edit-post.js

@@ -116 +116 @@
                 if ( 'post' === type ) {
                         $( 'tr.inline-editor textarea[data-wp-taxonomy]' ).each( function ( i, element ) {
+                                /*
+                                 * While Quick Edit clones the form each time, Bulk Edit always re-uses
+                                 * the same form. Let's check if an autocomplete instance already exists.
+                                 */
+                                if ( $( element ).autocomplete( 'instance' ) ) {
+                                        // jQuery equivalent of `continue` within an `each()` loop.
+                                        return;
+                                }
+
                                 $( element ).wpTagsSuggest();
                         } );

trunk/src/wp-admin/js/tags-suggest.js

@@ -121 +121 @@
                         minLength: 2,
                         position: {
-                                my: 'left top+2'
+                                my: 'left top+2',
+                                at: 'left bottom',
+                                collision: 'none'
                         },
                         messages: {