Changeset 40359

Timestamp:

03/31/2017 05:37:58 PM (6 years ago)

Author:

afercia

Message:

Accessibility: Improve the Media Library inline uploader accessibility.

For better accessibility, expandable panels should be placed immediately after
the control that expands them. This change moves the Media Library inline
uploader up, right after the "Add New" button, also introducing consistency with
the Plugin and Theme uploaders.
Adds a proper ARIA role on the button and an aria-expanded attribute to give
better feedback to assistive technologies users about the uploader's expanded state.
Improves the focus handling when closing the uploader, improves the focus style
and color contrast ratio of the uploader "close" button.

Props mantismamita, karmatosed, adamsilverstein, afercia.
Fixes #37188.

Location:

trunk/src

Files:

• wp-admin/css/media.css (modified) (2 diffs)
• wp-admin/upload.php (modified) (1 diff)
• wp-includes/css/media-views.css (modified) (1 diff)
• wp-includes/js/media-grid.js (modified) (1 diff)
• wp-includes/js/media-views.js (modified) (3 diffs)
• wp-includes/js/media/views/attachments/browser.js (modified) (2 diffs)
• wp-includes/js/media/views/frame/manage.js (modified) (1 diff)
• wp-includes/js/media/views/uploader/inline.js (modified) (1 diff)

trunk/src/wp-admin/css/media.css

@@ -470 +470 @@
     position: relative;
     width: auto;
-    margin-bottom: 16px;
+    margin-top: 12px;
     padding: 0 16px;
     border-left: 4px solid #dd3d36;
@@ -527 +527 @@
     bottom: auto;
     padding-top: 0;
-    margin-top: 0;
+    margin-top: 20px;
     border: 4px dashed #b4b9be;
 }

trunk/src/wp-admin/upload.php

@@ -78 +78 @@
         <?php
         if ( current_user_can( 'upload_files' ) ) { ?>
-            <a href="<?php echo admin_url( 'media-new.php' ); ?>" class="page-title-action"><?php echo esc_html_x( 'Add New', 'file' ); ?></a><?php
+            <a href="<?php echo admin_url( 'media-new.php' ); ?>" class="page-title-action aria-button-if-js"><?php echo esc_html_x( 'Add New', 'file' ); ?></a><?php
         }
         ?>

trunk/src/wp-includes/css/media-views.css

@@ -1134 +1134 @@
     cursor: pointer;
     height: 48px;
-    position: absolute;
-    right: 0;
+    outline: none;
+    padding: 0;
+    position: absolute;
+    right: 2px;
     text-align: center;
-    top: 0;
-    width: 50px;
+    top: 2px;
+    width: 48px;
     z-index: 1;
 }
 
 .uploader-inline .close:before {
-    font: normal 30px/50px dashicons !important;
-    color: #72777c;
+    font: normal 30px/1 dashicons !important;
+    color: #555d66;
     display: inline-block;
     content: "\f335";
     font-weight: 300;
+    margin-top: 1px;
+}
+
+.uploader-inline .close:focus {
+    outline: 1px solid  #5b9dd9;
+    -webkit-box-shadow: 0 0 3px rgba( 0, 115, 170, .8 );
+    box-shadow: 0 0 3px rgba( 0, 115, 170, .8 );
 }
 

trunk/src/wp-includes/js/media-grid.js

@@ -624 +624 @@
         this.$window = $( window );
         this.$adminBar = $( '#wpadminbar' );
+        // Store the Add New button for later reuse in wp.media.view.UploaderInline.
+        this.$uploaderToggler = $( '.page-title-action' )
+            .attr( 'aria-expanded', 'false' )
+            .on( 'click', _.bind( this.addNewClickHandler, this ) );
+
         this.$window.on( 'scroll resize', _.debounce( _.bind( this.fixPosition, this ), 15 ) );
-        $( document ).on( 'click', '.page-title-action', _.bind( this.addNewClickHandler, this ) );
 
         // Ensure core and media grid view UI is enabled.

trunk/src/wp-includes/js/media-views.js

@@ -3772 +3772 @@
         this.controller.on( 'toggle:upload:attachment', this.toggleUploader, this );
         this.controller.on( 'edit:selection', this.editSelection );
-        this.createToolbar();
+
         // In the Media Library, the sidebar is used to display errors before the attachments grid.
         if ( this.options.sidebar && 'errors' === this.options.sidebar ) {
             this.createSidebar();
         }
+
+        /*
+         * For accessibility reasons, place the Inline Uploader before other sections.
+         * This way, in the Media Library, it's right after the Add New button, see ticket #37188.
+         */
         this.createUploader();
+
+        /*
+         * Create a multi-purpose toolbar. Used as main toolbar in the Media Library
+         * and also for other things, for example the "Drag and drop to reorder" and
+         * "Suggested dimensions" info in the media modal.
+         */
+        this.createToolbar();
+
+        // Create the list of attachments.
         this.createAttachments();
+
         // For accessibility reasons, place the normal sidebar after the attachments, see ticket #36909.
         if ( this.options.sidebar && 'errors' !== this.options.sidebar ) {
             this.createSidebar();
         }
+
         this.updateContent();
 
@@ -4075 +4091 @@
         });
 
-        this.uploader.hide();
+        this.uploader.$el.addClass( 'hidden' );
         this.views.add( this.uploader );
     },
@@ -8211 +8227 @@
     show: function() {
         this.$el.removeClass( 'hidden' );
+        if ( this.controller.$uploaderToggler.length ) {
+            this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' );
+        }
     },
     hide: function() {
         this.$el.addClass( 'hidden' );
+        if ( this.controller.$uploaderToggler.length ) {
+            this.controller.$uploaderToggler
+                .attr( 'aria-expanded', 'false' )
+                // Move focus back to the toggle button when closing the uploader.
+                .focus();
+        }
     }
 

trunk/src/wp-includes/js/media/views/attachments/browser.js

@@ -41 +41 @@
         this.controller.on( 'toggle:upload:attachment', this.toggleUploader, this );
         this.controller.on( 'edit:selection', this.editSelection );
-        this.createToolbar();
+
         // In the Media Library, the sidebar is used to display errors before the attachments grid.
         if ( this.options.sidebar && 'errors' === this.options.sidebar ) {
             this.createSidebar();
         }
+
+        /*
+         * For accessibility reasons, place the Inline Uploader before other sections.
+         * This way, in the Media Library, it's right after the Add New button, see ticket #37188.
+         */
         this.createUploader();
+
+        /*
+         * Create a multi-purpose toolbar. Used as main toolbar in the Media Library
+         * and also for other things, for example the "Drag and drop to reorder" and
+         * "Suggested dimensions" info in the media modal.
+         */
+        this.createToolbar();
+
+        // Create the list of attachments.
         this.createAttachments();
+
         // For accessibility reasons, place the normal sidebar after the attachments, see ticket #36909.
         if ( this.options.sidebar && 'errors' !== this.options.sidebar ) {
             this.createSidebar();
         }
+
         this.updateContent();
 
@@ -344 +360 @@
         });
 
-        this.uploader.hide();
+        this.uploader.$el.addClass( 'hidden' );
         this.views.add( this.uploader );
     },

trunk/src/wp-includes/js/media/views/frame/manage.js

@@ -39 +39 @@
         this.$window = $( window );
         this.$adminBar = $( '#wpadminbar' );
+        // Store the Add New button for later reuse in wp.media.view.UploaderInline.
+        this.$uploaderToggler = $( '.page-title-action' )
+            .attr( 'aria-expanded', 'false' )
+            .on( 'click', _.bind( this.addNewClickHandler, this ) );
+
         this.$window.on( 'scroll resize', _.debounce( _.bind( this.fixPosition, this ), 15 ) );
-        $( document ).on( 'click', '.page-title-action', _.bind( this.addNewClickHandler, this ) );
 
         // Ensure core and media grid view UI is enabled.

trunk/src/wp-includes/js/media/views/uploader/inline.js

@@ -120 +120 @@
     show: function() {
         this.$el.removeClass( 'hidden' );
+        if ( this.controller.$uploaderToggler.length ) {
+            this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' );
+        }
     },
     hide: function() {
         this.$el.addClass( 'hidden' );
+        if ( this.controller.$uploaderToggler.length ) {
+            this.controller.$uploaderToggler
+                .attr( 'aria-expanded', 'false' )
+                // Move focus back to the toggle button when closing the uploader.
+                .focus();
+        }
     }