Changeset 40366 for branches/4.7

Timestamp:

04/03/2017 10:14:33 PM (9 years ago)

Author:

swissspidy

Message:

Customize: Fix selective refresh when customizing the 404 template.

Overrides the 404 status during partial refresh requests to serve back 200 so that the request is not deemed a failure and invoke the fallback behavior (full refresh).

See #27355.
Fixes #40018.

Merges [40316] to the 4.7 branch.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-includes/customize/class-wp-customize-selective-refresh.php (modified) (1 diff)

branches/4.7/src/wp-includes/customize/class-wp-customize-selective-refresh.php

@@ -325 +325 @@
                 if ( ! is_customize_preview() ) {
                         wp_send_json_error( 'expected_customize_preview', 403 );
-                } else if ( ! isset( $_POST['partials'] ) ) {
+                } elseif ( ! isset( $_POST['partials'] ) ) {
                         wp_send_json_error( 'missing_partials', 400 );
                 }
+
+                // Ensure that doing selective refresh on 404 template doesn't result in fallback rendering behavior (full refreshes).
+                status_header( 200 );
 
                 $partials = json_decode( wp_unslash( $_POST['partials'] ), true );