Changeset 40376

Timestamp:

04/05/2017 08:24:27 PM (8 years ago)

Author:

jnylen0

Message:

REST API: Allow fetching multiple terms at once via the slug parameter.

This matches a similar change previously made for posts (#38579) and an upcoming change for users (#40213).

Props wonderboymusic, MatheusGimenez, curdin.
Fixes #40027.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-tags-controller.php (modified) (1 diff)
• tests/qunit/fixtures/wp-api-generated.js (modified) (2 diffs)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-terms-controller.php

@@ -979 +979 @@
         $query_params['slug'] = array(
             'description'       => __( 'Limit result set to terms with a specific slug.' ),
-            'type'              => 'string',
+            'type'              => 'array',
+            'items'             => array(
+                'type'          => 'string'
+            ),
         );
 

trunk/tests/phpunit/tests/rest-api/rest-tags-controller.php

@@ -377 +377 @@
         $this->assertEquals( 1, count( $data ) );
         $this->assertEquals( 'Apple', $data[0]['name'] );
+    }
+
+    public function test_get_items_slug_array_arg() {
+        $id1 = $this->factory->tag->create( array( 'name' => 'Taco' ) );
+        $id2 = $this->factory->tag->create( array( 'name' => 'Enchilada' ) );
+        $id3 = $this->factory->tag->create( array( 'name' => 'Burrito' ) );
+        $this->factory->tag->create( array( 'name' => 'Pizza' ) );
+        $request = new WP_REST_Request( 'GET', '/wp/v2/tags' );
+        $request->set_param( 'slug', array(
+            'taco',
+            'burrito',
+            'enchilada',
+        ) );
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 200, $response->get_status() );
+        $data = $response->get_data();
+        $names = wp_list_pluck( $data, 'name' );
+        sort( $names );
+        $this->assertEquals( array( 'Burrito', 'Enchilada', 'Taco' ), $names );
+    }
+
+    public function test_get_items_slug_csv_arg() {
+        $id1 = $this->factory->tag->create( array( 'name' => 'Taco' ) );
+        $id2 = $this->factory->tag->create( array( 'name' => 'Enchilada' ) );
+        $id3 = $this->factory->tag->create( array( 'name' => 'Burrito' ) );
+        $this->factory->tag->create( array( 'name' => 'Pizza' ) );
+        $request = new WP_REST_Request( 'GET', '/wp/v2/tags' );
+        $request->set_param( 'slug', 'taco,burrito, enchilada');
+        $response = $this->server->dispatch( $request );
+        $this->assertEquals( 200, $response->get_status() );
+        $data = $response->get_data();
+        $names = wp_list_pluck( $data, 'name' );
+        sort( $names );
+        $this->assertEquals( array( 'Burrito', 'Enchilada', 'Taco' ), $names );
     }
 

trunk/tests/qunit/fixtures/wp-api-generated.js

@@ -1991 +1991 @@
                             "required": false,
                             "description": "Limit result set to terms with a specific slug.",
-                            "type": "string"
+                            "type": "array",
+                            "items": {
+                                "type": "string"
+                            }
                         }
                     }
@@ -2226 +2229 @@
                             "required": false,
                             "description": "Limit result set to terms with a specific slug.",
-                            "type": "string"
+                            "type": "array",
+                            "items": {
+                                "type": "string"
+                            }
                         }
                     }