Changeset 40392

Timestamp:

04/07/2017 01:37:39 PM (8 years ago)

Author:

johnbillion

Message:

Build/Test tools: Remove occurrences of create_function() in unit tests.

Props desrosj

See #37082

Location:

trunk/tests/phpunit/tests

Files:

• customize/setting.php (modified) (3 diffs)
• image/editor.php (modified) (2 diffs)

trunk/tests/phpunit/tests/customize/setting.php

@@ -49 +49 @@
     }
 
+    /**
+     * A test validate callback function.
+     *
+     * @param mixed                $value   The setting value.
+     * @param WP_Customize_Setting $setting The setting object.
+     */
+    public function validate_callback_for_tests( $value, $setting ) {
+        return $value . ':validate_callback';
+    }
+
+    /**
+     * A test sanitize callback function.
+     *
+     * @param mixed                $value   The setting value.
+     * @param WP_Customize_Setting $setting The setting object.
+     */
+    public function sanitize_callback_for_tests( $value, $setting ) {
+        return $value . ':sanitize_callback';
+    }
+
+    /**
+     * A test sanitize JS callback function.
+     *
+     * @param mixed                $value   The setting value.
+     * @param WP_Customize_Setting $setting The setting object.
+     */
+    public function sanitize_js_callback_for_tests( $value, $setting ) {
+        return $value . ':sanitize_js_callback';
+    }
+
+    /**
+     * Sanitize JS callback for base64 encoding.
+     *
+     * @param mixed                $value   The setting value.
+     * @param WP_Customize_Setting $setting The setting object.
+     */
+    function sanitize_js_callback_base64_for_testing( $value, $setting ) {
+        return base64_encode( $value );
+    }
+
     function test_constructor_with_args() {
         $args = array(
@@ -56 +96 @@
             'default' => 'barbar',
             'transport' => 'postMessage',
-            'validate_callback' => create_function( '$value', 'return $value . ":validate_callback";' ),
-            'sanitize_callback' => create_function( '$value', 'return $value . ":sanitize_callback";' ),
-            'sanitize_js_callback' => create_function( '$value', 'return $value . ":sanitize_js_callback";' ),
+            'validate_callback' => array( $this, 'validate_callback_for_tests' ),
+            'sanitize_callback' => array( $this, 'sanitize_callback_for_tests' ),
+            'sanitize_js_callback' => array( $this, 'sanitize_js_callback_for_tests' ),
         );
         $setting = new WP_Customize_Setting( $this->manager, 'bar', $args );
@@ -616 +656 @@
             'transport' => 'postMessage',
             'dirty' => true,
-            'sanitize_js_callback' => create_function( '$value', 'return base64_encode( $value );' ),
+            'sanitize_js_callback' => array( $this, 'sanitize_js_callback_base64_for_testing' ),
         );
         $setting = new WP_Customize_Setting( $this->manager, 'name', $args );

trunk/tests/phpunit/tests/image/editor.php

@@ -47 +47 @@
 
     /**
+     * Return integer of 95 for testing.
+     */
+    public function return_integer_95() {
+        return 95;
+    }
+
+    /**
+     * Return integer of 100 for testing.
+     */
+    public function return_integer_100() {
+        return 100;
+    }
+
+    /**
      * Test test_quality
      * @ticket 6821
@@ -60 +74 @@
 
         // Ensure the quality filters do not have precedence if created after editor instantiation.
-        $func_100_percent = create_function( '', "return 100;" );
+        $func_100_percent = array( $this, 'return_integer_100' );
         add_filter( 'wp_editor_set_quality', $func_100_percent );
         $this->assertEquals( 82, $editor->get_quality() );
 
-        $func_95_percent = create_function( '', "return 95;" );
+        $func_95_percent = array( $this, 'return_integer_95' );
         add_filter( 'jpeg_quality', $func_95_percent );
         $this->assertEquals( 82, $editor->get_quality() );