Changeset 40394

Timestamp:

04/07/2017 02:35:39 PM (8 years ago)

Author:

swissspidy

Message:

Upgrade/Install: Introduce wp_disallow_file_mods() helper function.

This is a wrapper around the checks for the DISALLOW_FILE_MODS constant to determine whether file modifications are disallowed.

Props MaximeCulea.
Fixes #38673.

Location:

trunk/src

Files:

• wp-admin/includes/class-wp-automatic-updater.php (modified) (1 diff)
• wp-admin/includes/dashboard.php (modified) (1 diff)
• wp-admin/includes/translation-install.php (modified) (2 diffs)
• wp-includes/capabilities.php (modified) (2 diffs)
• wp-includes/load.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-automatic-updater.php

@@ -32 +32 @@
     public function is_disabled() {
         // Background updates are disabled if you don't want file changes.
-        if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS )
+        if ( wp_disallow_file_mods( 'automatic_updater' ) )
             return true;
 

trunk/src/wp-admin/includes/dashboard.php

@@ -1153 +1153 @@
     );
 
-    if ( ( ! defined( 'DISALLOW_FILE_MODS' ) || ! DISALLOW_FILE_MODS ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) || ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {
+    if ( ( ! wp_disallow_file_mods( 'dashboard_widget' ) ) && ( ! is_multisite() && is_blog_admin() && current_user_can( 'install_plugins' ) ) || ( is_network_admin() && current_user_can( 'manage_network_plugins' ) && current_user_can( 'install_plugins' ) ) ) {
         $feeds['plugins'] = array(
             'link'         => '',

trunk/src/wp-admin/includes/translation-install.php

@@ -203 +203 @@
     }
 
-    if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+    if ( wp_disallow_file_mods( 'download_language_pack' ) ) {
         return false;
     }
@@ -246 +246 @@
  */
 function wp_can_install_language_pack() {
-    if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+    if ( wp_disallow_file_mods( 'can_install_language_pack' ) ) {
         return false;
     }

trunk/src/wp-includes/capabilities.php

@@ -363 +363 @@
         if ( defined( 'DISALLOW_FILE_EDIT' ) && DISALLOW_FILE_EDIT )
             $caps[] = 'do_not_allow';
-        elseif ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS )
+        elseif ( wp_disallow_file_mods( 'capability_edit_themes' ) )
             $caps[] = 'do_not_allow';
         elseif ( is_multisite() && ! is_super_admin( $user_id ) )
@@ -381 +381 @@
         // Disallow anything that creates, deletes, or updates core, plugin, or theme files.
         // Files in uploads are excepted.
-        if ( defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS ) {
+        if ( wp_disallow_file_mods( 'capability_update_core' ) ) {
             $caps[] = 'do_not_allow';
         } elseif ( is_multisite() && ! is_super_admin( $user_id ) ) {

trunk/src/wp-includes/load.php

@@ -1073 +1073 @@
     return ( $thing instanceof WP_Error );
 }
+
+/**
+ * Determines whether file modifications are disallowed.
+ *
+ * @since 4.8.0
+ *
+ * @param string $context The usage context.
+ * @return bool True if file modification is disallowed, false otherwise.
+ */
+function wp_disallow_file_mods( $context ) {
+    /**
+     * Filters whether file modifications are disallowed.
+     *
+     * @since 4.8.0
+     *
+     * @param bool   $disllow_file_mods Whether file modifications are disallowed.
+     * @param string $context           The usage context.
+     */
+    return apply_filters( 'disallow_file_mods' , defined( 'DISALLOW_FILE_MODS' ) && DISALLOW_FILE_MODS, $context );
+}