Changeset 40406 for trunk/src/wp-admin/includes/schema.php

Timestamp:

04/10/2017 09:59:59 PM (8 years ago)

Author:

flixos90

Message:

Multisite: Replace unnecessary is_super_admin() check when setting up the initial network.

When using is_super_admin() in a non-multisite environment, the function is supposed to check for administrator capabilities. The process of querying all users and filtering them with that function can be optimized by only querying users with the administrator role instead.

Fixes #40406. See #37616.

File:

• trunk/src/wp-admin/includes/schema.php (modified) (1 diff)

trunk/src/wp-admin/includes/schema.php

@@ -952 +952 @@
     if ( !is_multisite() ) {
         $site_admins = array( $site_user->user_login );
-        $users = get_users( array( 'fields' => array( 'ID', 'user_login' ) ) );
+        $users = get_users( array(
+            'fields' => array( 'user_login' ),
+            'role'   => 'administrator',
+        ) );
         if ( $users ) {
             foreach ( $users as $user ) {
-                if ( is_super_admin( $user->ID ) && !in_array( $user->user_login, $site_admins ) )
-                    $site_admins[] = $user->user_login;
+                $site_admins[] = $user->user_login;
             }
+
+            $site_admins = array_unique( $site_admins );
         }
     } else {