Changeset 40417 for trunk/tests/phpunit/tests/xmlrpc/mw/editPost.php

Timestamp:

04/12/2017 02:58:33 PM (8 years ago)

Author:

johnbillion

Message:

Build/Test tools: Introduce and implement assertNotIXRError() and assertIXRError() assertion methods.

This aids in debugging XMLRPC tests which fail, by exposing the IXR_Error error message in the assertion failure message.

Fixes #40423

File:

• trunk/tests/phpunit/tests/xmlrpc/mw/editPost.php (modified) (16 diffs)

trunk/tests/phpunit/tests/xmlrpc/mw/editPost.php

@@ -9 +9 @@
         $post = array();
         $result = $this->myxmlrpcserver->mw_editPost( array( 1, 'username', 'password', $post ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 403, $result->code );
     }
@@ -21 +21 @@
         $post2 = array( 'title' => $new_title );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -38 +38 @@
         $post2 = array( 'title' => $new_title );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'editor', 'editor', $post2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -56 +56 @@
         $post2 = array( 'title' => $new_title );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
 
@@ -73 +73 @@
         $post2 = array( 'wp_author_id' => $author_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'editor', 'editor', $post2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -89 +89 @@
         $post2 = array( 'wp_author_id' => $author_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
 
@@ -108 +108 @@
         $post2 = array( 'wp_author_id' => $editor_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'editor', 'editor', $post2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -132 +132 @@
         $post2 = array( 'wp_post_thumbnail' => $attachment_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'author', 'author', $post2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertEquals( $attachment_id, get_post_meta( $post_id, '_thumbnail_id', true ) );
 
@@ -138 +138 @@
         $post3 = array( 'post_content' => 'Updated post' );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'author', 'author', $post3 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertEquals( $attachment_id, get_post_meta( $post_id, '_thumbnail_id', true ) );
 
@@ -147 +147 @@
         $post4 = array( 'wp_post_thumbnail' => $attachment2_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'author', 'author', $post4 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertEquals( $attachment2_id, get_post_meta( $post_id, '_thumbnail_id', true ) );
 
@@ -153 +153 @@
         $post5 = array( 'wp_post_thumbnail' => '' );
         $result = $this->myxmlrpcserver->mw_editPost( array($post_id, 'author', 'author', $post5 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertEquals( '', get_post_meta( $post_id, '_thumbnail_id', true ) );
 
@@ -167 +167 @@
         $post2 = array( 'title' => 'New Title', 'post_author' => $contributor_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -175 +175 @@
         $post3 = array( 'description' => 'New Content', 'post_author' => $contributor_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post3 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -184 +184 @@
         $post4 = array( 'mt_excerpt' => 'New Excerpt', 'post_author' => $contributor_id );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post4 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue($result);
 
@@ -203 +203 @@
 
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'editor', 'editor', array( 'sticky' => '1' ) ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
         $this->assertTrue( $result );
     }
@@ -216 +216 @@
         $post2 = array( 'post_type' => 'page' );
         $result = $this->myxmlrpcserver->mw_editPost( array( $post_id, 'contributor', 'contributor', $post2 ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( $result->code, 401 );
     }