Changeset 40417 for trunk/tests/phpunit/tests/xmlrpc/mw/getPost.php

Timestamp:

04/12/2017 02:58:33 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test tools: Introduce and implement assertNotIXRError() and assertIXRError() assertion methods.

This aids in debugging XMLRPC tests which fail, by exposing the IXR_Error error message in the assertion failure message.

Fixes #40423

File:

• trunk/tests/phpunit/tests/xmlrpc/mw/getPost.php (modified) (6 diffs)

trunk/tests/phpunit/tests/xmlrpc/mw/getPost.php

@@ -20 +20 @@
     function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->mw_getPost( array( self::$post_id, 'username', 'password' ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 403, $result->code );
     }
@@ -28 +28 @@
 
         $result = $this->myxmlrpcserver->mw_getPost( array( self::$post_id, 'subscriber', 'subscriber' ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
     }
@@ -37 +37 @@
     function test_invalid_postid() {
         $result = $this->myxmlrpcserver->mw_getPost( array( 9999, 'author', 'author' ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 404, $result->code );
     }
@@ -46 +46 @@
         $fields = array( 'post' );
         $result = $this->myxmlrpcserver->mw_getPost( array( self::$post_id, 'author', 'author' ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
 
         // Check data types
@@ -97 +97 @@
         $fields = array( 'post' );
         $result = $this->myxmlrpcserver->mw_getPost( array( self::$post_id, 'author', 'author' ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
 
         $this->assertInternalType( 'string', $result['wp_post_thumbnail'] );
@@ -109 +109 @@
         $fields = array( 'post' );
         $result = $this->myxmlrpcserver->mw_getPost( array( self::$post_id, 'author', 'author' ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
 
         $this->assertInstanceOf( 'IXR_Date', $result['dateCreated'] );