Changeset 40417 for trunk/tests/phpunit/tests/xmlrpc/wp/getComment.php

Timestamp:

04/12/2017 02:58:33 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test tools: Introduce and implement assertNotIXRError() and assertIXRError() assertion methods.

This aids in debugging XMLRPC tests which fail, by exposing the IXR_Error error message in the assertion failure message.

Fixes #40423

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getComment.php (modified) (5 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getComment.php

@@ -36 +36 @@
     function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'username', 'password', self::$parent_comment_id ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 403, $result->code );
     }
@@ -44 +44 @@
 
         $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'contributor', 'contributor', self::$parent_comment_id ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 403, $result->code );
     }
@@ -52 +52 @@
 
         $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', self::$parent_comment_id ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
 
         // Check data types
@@ -88 +88 @@
 
         $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', self::$child_comment_id ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
 
         $this->assertEquals( self::$child_comment_id, $result['comment_id'] );
@@ -98 +98 @@
 
         $result = $this->myxmlrpcserver->wp_getComment( array( 1, 'editor', 'editor', 123456789 ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 404, $result->code );
     }