Changeset 40417 for trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php

Timestamp:

04/12/2017 02:58:33 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test tools: Introduce and implement assertNotIXRError() and assertIXRError() assertion methods.

This aids in debugging XMLRPC tests which fail, by exposing the IXR_Error error message in the assertion failure message.

Fixes #40423

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php (modified) (9 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getComments.php

@@ -9 +9 @@
     function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->wp_getComments( array( 1, 'username', 'password', array() ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 403, $result->code );
     }
@@ -17 +17 @@
 
         $result = $this->myxmlrpcserver->wp_getComments( array( 1, 'contributor', 'contributor', array() ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
     }
@@ -28 +28 @@
 
         $results = $this->myxmlrpcserver->wp_getComments( array( 1, 'editor', 'editor', array() ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
 
         foreach( $results as $result ) {
@@ -45 +45 @@
             'post_id' => $this->post_id
         ) ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
 
         foreach( $results as $result ) {
@@ -61 +61 @@
             'post_id' => $this->post_id,
         ) ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
 
         // if no 'number' filter is specified, default should be 10
@@ -70 +70 @@
             'number' => 5
         ) ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results2 );
+        $this->assertNotIXRError( $results2 );
         $this->assertCount( 5, $results2 );
     }
@@ -105 +105 @@
 
         $result = $this->myxmlrpcserver->wp_getComments( array( 1, 'contributor', 'contributor' ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
     }
@@ -141 +141 @@
             'post_id' => $author_post_id
         ) ) );
-        $this->assertInstanceOf( 'IXR_Error', $result1 );
+        $this->assertIXRError( $result1 );
 
         $result2 = $this->myxmlrpcserver->wp_getComments( array( 1, 'author', 'author', array(
@@ -154 +154 @@
             'post_id' => $editor_post_id
         ) ) );
-        $this->assertInstanceOf( 'IXR_Error', $result3 );
+        $this->assertIXRError( $result3 );
 
         $result4 = $this->myxmlrpcserver->wp_getComments( array( 1, 'author', 'author', array(