Changeset 40417 for trunk/tests/phpunit/tests/xmlrpc/wp/getPosts.php

Timestamp:

04/12/2017 02:58:33 PM (8 years ago)

Author:

johnbillion

Message:

Build/Test tools: Introduce and implement assertNotIXRError() and assertIXRError() assertion methods.

This aids in debugging XMLRPC tests which fail, by exposing the IXR_Error error message in the assertion failure message.

Fixes #40423

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getPosts.php (modified) (11 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getPosts.php

@@ -8 +8 @@
     function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->wp_getPosts( array( 1, 'username', 'password' ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 403, $result->code );
     }
@@ -19 +19 @@
 
         $result = $this->myxmlrpcserver->wp_getPosts( array( 1, 'subscriber', 'subscriber' ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
 
         $filter = array( 'post_type' => 'page' );
         $result = $this->myxmlrpcserver->wp_getPosts( array( 1, 'subscriber', 'subscriber', $filter ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
         $this->assertEquals( 401, $result->code );
     }
@@ -32 +32 @@
 
         $result = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor' ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
     }
 
@@ -40 +40 @@
         $filter = array( 'post_type' => 'invalid_post_type_name' );
         $result = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
-        $this->assertInstanceOf( 'IXR_Error', $result );
+        $this->assertIXRError( $result );
     }
 
@@ -63 +63 @@
         $filter = array( 'post_type' => $cpt_name, 'number' => $num_posts + 10 );
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
         $this->assertEquals( $num_posts, count( $results ) );
 
@@ -87 +87 @@
         $filter2 = array( 'post_type' => $cpt_name, 'number' => $num_posts, 'orderby' => 'comment_count', 'order' => 'DESC' );
         $results2 = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results2 );
+        $this->assertNotIXRError( $results2 );
         $last_comment_count = 100;
         foreach ( $results2 as $post ) {
@@ -101 +101 @@
         $filter3 = array( 'post_type' => $cpt_name, 'post_status' => 'draft' );
         $results3 = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter3 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results3 );
+        $this->assertNotIXRError( $results3 );
         $this->assertEquals( 1, count( $results3 ) );
         $this->assertEquals( $post->ID, $results3[0]['post_id'] );
@@ -114 +114 @@
         // check default fields
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor' ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
         $expected_fields = array( 'post_id', 'post_title', 'terms', 'custom_fields', 'link' ); // subset of expected fields
         foreach( $expected_fields as $field ) {
@@ -124 +124 @@
         $fields = array( 'post_name', 'post_author', 'enclosure' );
         $results2 = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter, $fields ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results2 );
+        $this->assertNotIXRError( $results2 );
         $expected_fields = array_merge( $fields, array( 'post_id' ) );
         foreach ( array_keys( $results2[0] ) as $field ) {
@@ -143 +143 @@
         $filter = array( 's' => 'Third' );
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
         $this->assertEquals( 0, count( $results ) );
 
@@ -149 +149 @@
         $filter = array( 's' => 'First:' );
         $results = $this->myxmlrpcserver->wp_getPosts( array( 1, 'editor', 'editor', $filter ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
         $this->assertEquals( 1, count( $results ) );
     }