Changeset 40417 for trunk/tests/phpunit/tests/xmlrpc/wp/getUsers.php

Timestamp:

04/12/2017 02:58:33 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test tools: Introduce and implement assertNotIXRError() and assertIXRError() assertion methods.

This aids in debugging XMLRPC tests which fail, by exposing the IXR_Error error message in the assertion failure message.

Fixes #40423

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getUsers.php (modified) (7 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getUsers.php

@@ -9 +9 @@
     function test_invalid_username_password() {
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'username', 'password' ) );
-        $this->assertInstanceOf( 'IXR_Error', $results );
+        $this->assertIXRError( $results );
         $this->assertEquals( 403, $results->code );
     }
@@ -17 +17 @@
 
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'subscriber', 'subscriber' ) );
-        $this->assertInstanceOf( 'IXR_Error', $results );
+        $this->assertIXRError( $results );
         $this->assertEquals( 401, $results->code );
     }
@@ -25 +25 @@
 
         $result = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator' ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $result );
+        $this->assertNotIXRError( $result );
 
         // check data types
@@ -50 +50 @@
         $filter = array( 'role' => 'invalidrole' );
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
-        $this->assertInstanceOf( 'IXR_Error', $results );
+        $this->assertIXRError( $results );
         $this->assertEquals( 403, $results->code );
     }
@@ -64 +64 @@
         $filter = array( 'role' => 'editor' );
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
         $this->assertCount( 1, $results );
         $this->assertEquals( $editor_id, $results[0]['user_id'] );
@@ -71 +71 @@
         $filter2 = array( 'who' => 'authors' );
         $results2 = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter2 ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results2 );
+        $this->assertNotIXRError( $results2 );
         $this->assertCount( 3, array_intersect( array( $author_id, $editor_id, $administrator_id ), wp_list_pluck( $results2, 'user_id' ) ) );
     }
@@ -105 +105 @@
         $filter = array( 'orderby' => 'email', 'order' => 'ASC' );
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
-        $this->assertNotInstanceOf( 'IXR_Error', $results );
+        $this->assertNotIXRError( $results );
 
         $last_email = '';