Changeset 40459

Timestamp:

04/17/2017 10:23:25 AM (8 years ago)

Author:

swissspidy

Message:

Twenty Seventeen: Correct heading hierarchy for posts on the front page.

When the posts page is on the front page or within a front page section, the heading hierarchy for the individual post titles needs to be adjusted accordingly.

Props joedolson, celloexpressions, davidakennedy.
Fixes #40264.

Merges [40458] to the 4.7 branch.

Location:

branches/4.7

Files:

• . (modified) (1 prop)
• src/wp-content/themes/twentyseventeen/style.css (modified) (2 diffs)
• src/wp-content/themes/twentyseventeen/template-parts/post/content-audio.php (modified) (1 diff)
• src/wp-content/themes/twentyseventeen/template-parts/post/content-excerpt.php (modified) (1 diff)
• src/wp-content/themes/twentyseventeen/template-parts/post/content-gallery.php (modified) (1 diff)
• src/wp-content/themes/twentyseventeen/template-parts/post/content-image.php (modified) (1 diff)
• src/wp-content/themes/twentyseventeen/template-parts/post/content-video.php (modified) (1 diff)
• src/wp-content/themes/twentyseventeen/template-parts/post/content.php (modified) (1 diff)

branches/4.7/src/wp-content/themes/twentyseventeen/style.css

@@ -452 +452 @@
 }
 
-h2 {
+h2,
+.home.blog .entry-title {
     color: #666;
     font-size: 20px;
@@ -3146 +3147 @@
 
     h2,
+    .home.blog .entry-title,
     .page .panel-content .recent-posts .entry-title {
         font-size: 26px;

branches/4.7/src/wp-content/themes/twentyseventeen/template-parts/post/content-audio.php

@@ -34 +34 @@
             if ( is_single() ) {
                 the_title( '<h1 class="entry-title">', '</h1>' );
+            } elseif ( is_front_page() && is_home() ) {
+                the_title( '<h3 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h3>' );
             } else {
                 the_title( '<h2 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h2>' );

branches/4.7/src/wp-content/themes/twentyseventeen/template-parts/post/content-excerpt.php

@@ -31 +31 @@
         <?php endif; ?>
 
-        <?php the_title( sprintf( '<h2 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h2>' ); ?>
+        <?php if ( is_front_page() && ! is_home() ) {
+
+            // The excerpt is being displayed within a front page section, so it's a lower hierarchy than h2.
+            the_title( sprintf( '<h3 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h3>' );
+        } else {
+            the_title( sprintf( '<h2 class="entry-title"><a href="%s" rel="bookmark">', esc_url( get_permalink() ) ), '</a></h2>' );
+        } ?>
     </header><!-- .entry-header -->
 

branches/4.7/src/wp-content/themes/twentyseventeen/template-parts/post/content-gallery.php

@@ -33 +33 @@
             if ( is_single() ) {
                 the_title( '<h1 class="entry-title">', '</h1>' );
+            } elseif ( is_front_page() && is_home() ) {
+                the_title( '<h3 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h3>' );
             } else {
                 the_title( '<h2 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h2>' );

branches/4.7/src/wp-content/themes/twentyseventeen/template-parts/post/content-image.php

@@ -33 +33 @@
             if ( is_single() ) {
                 the_title( '<h1 class="entry-title">', '</h1>' );
+            } elseif ( is_front_page() && is_home() ) {
+                the_title( '<h3 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h3>' );
             } else {
                 the_title( '<h2 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h2>' );

branches/4.7/src/wp-content/themes/twentyseventeen/template-parts/post/content-video.php

@@ -33 +33 @@
             if ( is_single() ) {
                 the_title( '<h1 class="entry-title">', '</h1>' );
+            } elseif ( is_front_page() && is_home() ) {
+                the_title( '<h3 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h3>' );
             } else {
                 the_title( '<h2 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h2>' );

branches/4.7/src/wp-content/themes/twentyseventeen/template-parts/post/content.php

@@ -34 +34 @@
             if ( is_single() ) {
                 the_title( '<h1 class="entry-title">', '</h1>' );
+            } elseif ( is_front_page() && is_home() ) {
+                the_title( '<h3 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h3>' );
             } else {
                 the_title( '<h2 class="entry-title"><a href="' . esc_url( get_permalink() ) . '" rel="bookmark">', '</a></h2>' );