Changeset 40464

Timestamp:

04/17/2017 01:18:30 PM (7 years ago)

Author:

swissspidy

Message:

Fix broken audio/video functions when sanitizing ID3 data

This fixes a bug where running wp_kses_post_deep() on all the ID3
tag data corrupted blob data.

See #40075, #40085.

Merges [40400] to the 4.3 branch.

Location:

branches/4.3

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/media.php (modified) (3 diffs)

branches/4.3/src/wp-admin/includes/media.php

@@ -2924 +2924 @@
             foreach ( $data[$version]['comments'] as $key => $list ) {
                 if ( 'length' !== $key && ! empty( $list ) ) {
-                    $metadata[$key] = reset( $list );
+                    $metadata[$key] = wp_kses_post( reset( $list ) );
                     // Fix bug in byte stream analysis.
                     if ( 'terms_of_use' === $key && 0 === strpos( $metadata[$key], 'yright notice.' ) )
@@ -3008 +3008 @@
     wp_add_id3_tag_data( $metadata, $data );
 
-    $metadata = wp_kses_post_deep( $metadata );
-
     return $metadata;
 }
@@ -3049 +3047 @@
     wp_add_id3_tag_data( $metadata, $data );
 
-    $metadata = wp_kses_post_deep( $metadata );
-
     return $metadata;
 }