Changeset 40519

Timestamp:

04/22/2017 06:44:18 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Don't skip tests when php.net or dev.mysql.com are unreachable.

This sort of behaviour subtly hides the fact that these tests will never fail if the URLs where version number information is fetched from go away for one reason or another.

See #40533

File:

• trunk/tests/phpunit/tests/external-http/basic.php (modified) (2 diffs)

trunk/tests/phpunit/tests/external-http/basic.php

@@ -15 +15 @@
         $response = wp_remote_get( 'https://secure.php.net/supported-versions.php' );
         if ( 200 != wp_remote_retrieve_response_code( $response ) ) {
-            $this->markTestSkipped( 'Could not contact PHP.net to check versions.' );
+            $this->fail( 'Could not contact PHP.net to check versions.' );
         }
         $php = wp_remote_retrieve_body( $response );
@@ -27 +27 @@
         $response = wp_remote_get( "https://dev.mysql.com/doc/relnotes/mysql/{$matches[1]}/en/" );
         if ( 200 != wp_remote_retrieve_response_code( $response ) ) {
-            $this->markTestSkipped( 'Could not contact dev.MySQL.com to check versions.' );
+            $this->fail( 'Could not contact dev.MySQL.com to check versions.' );
         }
         $mysql = wp_remote_retrieve_body( $response );