Changeset 40541

Timestamp:

04/23/2017 09:28:44 PM (7 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Only perform an assertion for deprecated calls and wrongdoings if any are expected.

This avoids masking risky tests that don't otherwise perform an assertion.

See #40538

File:

• trunk/tests/phpunit/includes/testcase.php (modified) (1 diff)

trunk/tests/phpunit/includes/testcase.php

@@ -389 +389 @@
         }
 
-        $this->assertEmpty( $errors, implode( "\n", $errors ) );
+        // Perform an assertion, but only if there are expected deprecated calls or expected wrongdoings
+        if ( ! empty( $this->expected_deprecated ) || ! empty( $this->expected_doing_it_wrong ) ) {
+            $this->assertEmpty( $errors, implode( "\n", $errors ) );
+        }
     }