WordPress.org

Make WordPress Core

Changeset 40544


Ignore:
Timestamp:
04/23/2017 10:11:52 PM (3 years ago)
Author:
johnbillion
Message:

Build/Test Tools: Remove more unnecessary test skipping when erroneous situations occur.

See #40533

Location:
trunk/tests/phpunit/tests
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/ajax/Compression.php

    r37150 r40544  
    5858
    5959        if ( !function_exists( 'gzdeflate' ) ) {
    60             $this->markTestSkipped( 'gzdeflate function not available' );
     60            $this->fail( 'gzdeflate function not available' );
    6161        }
    6262
     
    8585
    8686        if ( !function_exists('gzencode') ) {
    87             $this->markTestSkipped( 'gzencode function not available' );
     87            $this->fail( 'gzencode function not available' );
    8888        }
    8989
  • trunk/tests/phpunit/tests/db.php

    r40529 r40544  
    508508        if ( count( $wpdb->get_results( 'SHOW CREATE PROCEDURE `test_mysqli_flush_sync_procedure`' ) ) < 1 ) {
    509509            $wpdb->suppress_errors( $suppress );
    510             $this->markTestSkipped( 'procedure could not be created (missing privileges?)' );
     510            $this->fail( 'procedure could not be created (missing privileges?)' );
    511511        }
    512512
  • trunk/tests/phpunit/tests/functions/deprecated.php

    r29120 r40544  
    141141    public function test_wp_save_image_file_deprecated_with_gd_resource() {
    142142        if ( !function_exists( 'imagejpeg' ) )
    143             $this->markTestSkipped( 'jpeg support unavailable' );
     143            $this->fail( 'jpeg support unavailable' );
    144144
    145145        // Call wp_save_image_file
     
    162162    public function test_wp_save_image_file_not_deprecated_with_wp_image_editor() {
    163163        if ( !function_exists( 'imagejpeg' ) )
    164             $this->markTestSkipped( 'jpeg support unavailable' );
     164            $this->fail( 'jpeg support unavailable' );
    165165
    166166        // Call wp_save_image_file
  • trunk/tests/phpunit/tests/image/meta.php

    r38761 r40544  
    1212        if ( ! extension_loaded( 'exif' ) )
    1313            $this->markTestSkipped( 'The exif PHP extension is not loaded.' );
    14         if ( ! is_callable( 'wp_read_image_metadata' ) )
    15             $this->markTestSkipped( 'wp_read_image_metadata() is not callable.' );
    1614        parent::setUp();
    1715    }
Note: See TracChangeset for help on using the changeset viewer.