Changeset 40544

Timestamp:

04/23/2017 10:11:52 PM (9 years ago)

Author:

johnbillion

Message:

Build/Test Tools: Remove more unnecessary test skipping when erroneous situations occur.

See #40533

Location:

trunk/tests/phpunit/tests

Files:

• ajax/Compression.php (modified) (2 diffs)
• db.php (modified) (1 diff)
• functions/deprecated.php (modified) (2 diffs)
• image/meta.php (modified) (1 diff)

trunk/tests/phpunit/tests/ajax/Compression.php

@@ -58 +58 @@
 
                 if ( !function_exists( 'gzdeflate' ) ) {
-                        $this->markTestSkipped( 'gzdeflate function not available' );
+                        $this->fail( 'gzdeflate function not available' );
                 }
 
@@ -85 +85 @@
 
                 if ( !function_exists('gzencode') ) {
-                        $this->markTestSkipped( 'gzencode function not available' );
+                        $this->fail( 'gzencode function not available' );
                 }
 

trunk/tests/phpunit/tests/db.php

@@ -508 +508 @@
                 if ( count( $wpdb->get_results( 'SHOW CREATE PROCEDURE `test_mysqli_flush_sync_procedure`' ) ) < 1 ) {
                         $wpdb->suppress_errors( $suppress );
-                        $this->markTestSkipped( 'procedure could not be created (missing privileges?)' );
+                        $this->fail( 'procedure could not be created (missing privileges?)' );
                 }
 

trunk/tests/phpunit/tests/functions/deprecated.php

@@ -141 +141 @@
         public function test_wp_save_image_file_deprecated_with_gd_resource() {
                 if ( !function_exists( 'imagejpeg' ) )
-                        $this->markTestSkipped( 'jpeg support unavailable' );
+                        $this->fail( 'jpeg support unavailable' );
 
                 // Call wp_save_image_file
@@ -162 +162 @@
         public function test_wp_save_image_file_not_deprecated_with_wp_image_editor() {
                 if ( !function_exists( 'imagejpeg' ) )
-                        $this->markTestSkipped( 'jpeg support unavailable' );
+                        $this->fail( 'jpeg support unavailable' );
 
                 // Call wp_save_image_file

trunk/tests/phpunit/tests/image/meta.php

@@ -12 +12 @@
                 if ( ! extension_loaded( 'exif' ) )
                         $this->markTestSkipped( 'The exif PHP extension is not loaded.' );
-                if ( ! is_callable( 'wp_read_image_metadata' ) )
-                        $this->markTestSkipped( 'wp_read_image_metadata() is not callable.' );
                 parent::setUp();
         }