Changeset 40556

Timestamp:

04/25/2017 04:41:26 PM (8 years ago)

Author:

afercia

Message:

Widgets: Improve the News dashboard widget no-js notice.

In the rare case this notice was displayed, it was unstyled. Uses the notice
error style to make it prettier and consistent with other no-js notices.
Also, some CSS clean-up.

Fixes #40529.

Location:

trunk/src/wp-admin

Files:

• css/dashboard.css (modified) (2 diffs)
• includes/dashboard.php (modified) (2 diffs)

trunk/src/wp-admin/css/dashboard.css

@@ -309 +309 @@
 }
 
-#dashboard_primary .widget-loading,
-#dashboard_primary .dashboard-widget-control-form {
+#dashboard_primary .widget-loading {
     padding: 12px 12px 0;
+    margin-bottom: 1em !important; /* Needs to override `.postbox .inside > p:last-child` in common.css */
+}
+
+/* Notice when JS is off. */
+#dashboard_primary .inside .notice {
+    margin: 0;
 }
 
@@ -318 +323 @@
 }
 
-.dashboard-widget-control-form {
-    overflow: hidden;
-}
-
+/* Used only for configurable widgets. */
 .dashboard-widget-control-form p {
     margin-top: 0;

trunk/src/wp-admin/includes/dashboard.php

@@ -192 +192 @@
  */
 function _wp_dashboard_control_callback( $dashboard, $meta_box ) {
-    echo '<form method="post" class="dashboard-widget-control-form">';
+    echo '<form method="post" class="dashboard-widget-control-form wp-clearfix">';
     wp_dashboard_trigger_widget_control( $meta_box['id'] );
     wp_nonce_field( 'edit-dashboard-widget_' . $meta_box['id'], 'dashboard-widget-nonce' );
@@ -969 +969 @@
  */
 function wp_dashboard_cached_rss_widget( $widget_id, $callback, $check_urls = array() ) {
-    $loading = '<p class="widget-loading hide-if-no-js">' . __( 'Loading&#8230;' ) . '</p><p class="hide-if-js">' . __( 'This widget requires JavaScript.' ) . '</p>';
+    $loading = '<p class="widget-loading hide-if-no-js">' . __( 'Loading&#8230;' ) . '</p><div class="hide-if-js notice notice-error inline"><p>' . __( 'This widget requires JavaScript.' ) . '</p></div>';
     $doing_ajax = wp_doing_ajax();