Changeset 40557 for trunk/tests/phpunit/tests/comment/checkComment.php

Timestamp:

04/27/2017 04:22:36 PM (8 years ago)

Author:

boonebgorges

Message:

Fix broken check_comment() test.

The test Tests_Comment_CheckComment::test_should_return_true_when_content_does_not_match_moderation_keys()
did not, in fact, test for a true value, but for a false one.
Switching to assertTrue() caused a failure, because the test comment
triggered the 'comment_moderation' test. As in other tests in the file,
the solution is to force 'comment_moderation' to 0 for the purposes of
the test.

Introduced in [32519].

Props stephdau.
Fixes #40584.

File:

• trunk/tests/phpunit/tests/comment/checkComment.php (modified) (2 diffs)

trunk/tests/phpunit/tests/comment/checkComment.php

@@ -84 +84 @@
 
     public function test_should_return_true_when_content_does_not_match_moderation_keys() {
+        update_option( 'comment_whitelist', 0 );
+
         $author       = 'WendytheBuilder';
         $author_email = 'wendy@example.com';
@@ -94 +96 @@
         update_option( 'moderation_keys',"foo\nbar" );
         $results = check_comment( $author, $author_email, $author_url, $comment, $author_ip, $user_agent, $comment_type );
-        $this->assertFalse( $results );
+        $this->assertTrue( $results );
     }