Changeset 40572

Timestamp:

05/05/2017 07:01:12 PM (8 years ago)

Author:

afercia

Message:

Accessibility: Wrap the installed themes search field within a form element.

Valid code is important not just to formally meet the specification, but also to
ensure user agents, including assistive technologies, can accurately interpret
and parse content. When HTML elements are not used in the recommended way,
user agents may render them in unexpected ways. It can also become a problem for
compatibility with older or even future browsers, devices, or other software.
See W3C WCAG 4.1.1.

Props takayukister, aryamaaru.
Fixes #34881.

Location:

trunk/src/wp-admin

Files:

• css/themes.css (modified) (1 diff)
• js/theme.js (modified) (1 diff)
• themes.php (modified) (1 diff)

trunk/src/wp-admin/css/themes.css

@@ -21 +21 @@
 
 /* Search form */
+.themes-php .wp-filter-search-form {
+    display: inline;
+}
+
 .themes-php .wp-filter-search {
     position: relative;

trunk/src/wp-admin/js/theme.js

@@ -84 +84 @@
 
     // Defines search element container
-    searchContainer: $( '.search-form' ),
+    searchContainer: $( '.wp-filter-search-form' ),
 
     // Search input and view

trunk/src/wp-admin/themes.php

@@ -161 +161 @@
     <?php endif; ?>
 
-    <span class="search-form"></span>
+    <form class="wp-filter-search-form"></form>
 
     <hr class="wp-header-end">