Changeset 40573

Timestamp:

05/05/2017 11:28:41 PM (8 years ago)

Author:

afercia

Message:

Accessibility: Improve the suggested image size text in the media views.

Adds pixels as unit, avoiding abbreviation for a clearer pronunciation by screen
readers. Also, adds the word by instead of the special character times.

Props Presskopp, stormrockwell.
Fixes #38932.

Location:

trunk/src/wp-includes

Files:

• js/media-views.js (modified) (1 diff)
• js/media/views/attachments/browser.js (modified) (1 diff)
• media-template.php (modified) (1 diff)
• media.php (modified) (1 diff)

trunk/src/wp-includes/js/media-views.js

@@ -4051 +4051 @@
         if ( this.options.suggestedWidth && this.options.suggestedHeight ) {
             this.toolbar.set( 'suggestedDimensions', new View({
-                el: $( '<div class="instructions">' + l10n.suggestedDimensions + ' ' + this.options.suggestedWidth + ' &times; ' + this.options.suggestedHeight + '</div>' )[0],
+                el: $( '<div class="instructions">' + l10n.suggestedDimensions.replace( '%1$s', this.options.suggestedWidth ).replace( '%2$s', this.options.suggestedHeight ) + '</div>' )[0],
                 priority: -40
             }) );

trunk/src/wp-includes/js/media/views/attachments/browser.js

@@ -320 +320 @@
         if ( this.options.suggestedWidth && this.options.suggestedHeight ) {
             this.toolbar.set( 'suggestedDimensions', new View({
-                el: $( '<div class="instructions">' + l10n.suggestedDimensions + ' ' + this.options.suggestedWidth + ' &times; ' + this.options.suggestedHeight + '</div>' )[0],
+                el: $( '<div class="instructions">' + l10n.suggestedDimensions.replace( '%1$s', this.options.suggestedWidth ).replace( '%2$s', this.options.suggestedHeight ) + '</div>' )[0],
                 priority: -40
             }) );

trunk/src/wp-includes/media-template.php

@@ -236 +236 @@
                 <# if ( data.suggestedWidth && data.suggestedHeight ) { #>
                     <p class="suggested-dimensions">
-                        <?php _e( 'Suggested image dimensions:' ); ?> {{data.suggestedWidth}} &times; {{data.suggestedHeight}}
+                        <?php
+                            /* translators: 1: suggested width number, 2: suggested height number. */
+                            printf( __( 'Suggested image dimensions: %1$s by %2$s pixels.' ), '{{data.suggestedWidth}}', '{{data.suggestedHeight}}' );
+                        ?>
                     </p>
                 <# } #>

trunk/src/wp-includes/media.php

@@ -3545 +3545 @@
         'cropYourImage' => __( 'Crop your image' ),
         'cropping' => __( 'Cropping…' ),
-        'suggestedDimensions' => __( 'Suggested image dimensions:' ),
+        /* translators: 1: suggested width number, 2: suggested height number. */
+        'suggestedDimensions' => __( 'Suggested image dimensions: %1$s by %2$s pixels.' ),
         'cropError' => __( 'There has been an error cropping your image.' ),