Changeset 40598

Timestamp:

05/10/2017 02:46:24 AM (7 years ago)

Author:

azaozz

Message:

Editor: Add init and remove methods to Quicktags.

Props helgatheviking azaozz.
Fixes #26183 #40708.

File:

• trunk/src/wp-includes/js/quicktags.js (modified) (8 diffs)

trunk/src/wp-includes/js/quicktags.js

@@ -224 +224 @@
         if ( tb.addEventListener ) {
             tb.addEventListener( 'click', onclick, false );
-            
+
             if ( wrap ) {
                 wrap.addEventListener( 'click', setActiveEditor, false );
@@ -244 +244 @@
         };
 
+        t.init = function() {
+            _domReady( function(){ qt._buttonsInit( id ); } );
+        };
+
+        t.remove = function() {
+            delete qt.instances[id];
+
+            if ( tb && tb.parentNode ) {
+                tb.parentNode.removeChild( tb );
+            }
+        };
+
         qt.instances[id] = t;
-
-        if ( ! qt.instances['0'] ) {
-            qt.instances['0'] = qt.instances[id];
-            _domReady( function(){ qt._buttonsInit(); } );
-        }
+        t.init();
     };
 
@@ -264 +272 @@
     };
 
-    qt._buttonsInit = function() {
-        var t = this, canvas, name, settings, theButtons, html, inst, ed, id, i, use,
-            defaults = ',strong,em,link,block,del,ins,img,ul,ol,li,code,more,close,';
-
-        for ( inst in t.instances ) {
-            if ( '0' === inst ) {
-                continue;
-            }
-
-            ed = t.instances[inst];
+    qt._buttonsInit = function( id ) {
+        var t = this;
+
+        function _init( instanceId ) {
+            var canvas, name, settings, theButtons, html, ed, id, i, use,
+                defaults = ',strong,em,link,block,del,ins,img,ul,ol,li,code,more,close,';
+
+            ed = t.instances[instanceId];
             canvas = ed.canvas;
             name = ed.name;
@@ -287 +293 @@
 
             for ( i in edButtons ) {
-                if ( !edButtons[i] ) {
+                if ( ! edButtons[i] ) {
                     continue;
                 }
@@ -296 +302 @@
                 }
 
-                if ( !edButtons[i].instance || edButtons[i].instance === inst ) {
+                if ( ! edButtons[i].instance || edButtons[i].instance === instanceId ) {
                     theButtons[id] = edButtons[i];
 
                     if ( edButtons[i].html ) {
-                        html += edButtons[i].html(name + '_');
+                        html += edButtons[i].html( name + '_' );
                     }
                 }
@@ -310 +316 @@
             }
 
-            if ( 'rtl' === document.getElementsByTagName('html')[0].dir ) {
+            if ( 'rtl' === document.getElementsByTagName( 'html' )[0].dir ) {
                 theButtons.textdirection = new qt.TextDirectionButton();
-                html += theButtons.textdirection.html(name + '_');
+                html += theButtons.textdirection.html( name + '_' );
             }
 
@@ -322 +328 @@
             }
         }
+
+        if ( id ) {
+            _init( id );
+        } else {
+            for ( id in t.instances ) {
+                _init( id );
+            }
+        }
+
         t.buttonsInitDone = true;
     };
@@ -607 +622 @@
     qt.CloseButton.prototype.callback = qt._close;
 
-    qt.closeAllTags = function(editor_id) {
-        var ed = this.getInstance(editor_id);
-        qt._close('', ed.canvas, ed);
+    qt.closeAllTags = function( editor_id ) {
+        var ed = this.getInstance( editor_id );
+
+        if ( ed ) {
+            qt._close( '', ed.canvas, ed );
+        }
     };