Changeset 40601

Timestamp:

05/10/2017 04:31:28 AM (8 years ago)

Author:

rmccue

Message:

REST API: Set global $post when preparing revisions.

For compatibility with filters on hooks on content filters (such as shortcodes), we need to set the global. This mirrors the Posts controller.

Props pdufour, jnylen0.
Fixes #40626.

Location:

trunk

Files:

• src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-revisions-controller.php (modified) (1 diff)

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

@@ -339 +339 @@
      */
     public function prepare_item_for_response( $post, $request ) {
+        $GLOBALS['post'] = $post;
+
+        setup_postdata( $post );
 
         $schema = $this->get_item_schema();

trunk/tests/phpunit/tests/rest-api/rest-revisions-controller.php

@@ -336 +336 @@
     }
 
+    public function test_get_item_sets_up_postdata() {
+        wp_set_current_user( self::$editor_id );
+        $request = new WP_REST_Request( 'GET', '/wp/v2/posts/' . self::$post_id . '/revisions/' . $this->revision_id1 );
+        $this->server->dispatch( $request );
+
+        $post = get_post();
+        $parent_post_id = wp_is_post_revision( $post->ID );
+
+        $this->assertEquals( $post->ID, $this->revision_id1 );
+        $this->assertEquals( $parent_post_id, self::$post_id );
+    }
+
 }