Changeset 40643

Timestamp:

05/11/2017 10:46:59 PM (7 years ago)

Author:

afercia

Message:

Accessibility: Add "(opens in a new window)" screen reader text to the "News-Nearby Events" dashboard widget footer links.

• standardizes similar messages in core to always use (opens in a new window)
• adds translators comments
• hides the dashicons with aria-hidden="true", see #40428

Fixes #40733.

Location:

trunk/src

Files:

• wp-admin/css/dashboard.css (modified) (1 diff)
• wp-admin/includes/dashboard.php (modified) (1 diff)
• wp-admin/includes/meta-boxes.php (modified) (1 diff)
• wp-includes/class-wp-customize-manager.php (modified) (1 diff)

trunk/src/wp-admin/css/dashboard.css

@@ -441 +441 @@
 }
 
+/* Safari 10 + VoiceOver specific: without this, the hidden text gets read out before the link. */
+.community-events-footer .screen-reader-text {
+    height: inherit;
+    white-space: nowrap;
+}
+
 /* Dashboard WordPress news */
 

trunk/src/wp-admin/includes/dashboard.php

@@ -1126 +1126 @@
 
     <p class="community-events-footer">
-        <a href="https://make.wordpress.org/community/meetups-landing-page" target="_blank">
-            <?php _e( 'Meetups' ); ?> <span class="dashicons dashicons-external"></span>
-        </a>
+        <?php
+            printf(
+                '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
+                'https://make.wordpress.org/community/meetups-landing-page',
+                __( 'Meetups' ),
+                /* translators: accessibility text */
+                __( '(opens in a new window)' )
+            );
+        ?>
 
         |
 
-        <a href="https://central.wordcamp.org/schedule/" target="_blank">
-            <?php _e( 'WordCamps' ); ?> <span class="dashicons dashicons-external"></span>
-        </a>
+        <?php
+            printf(
+                '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
+                'https://central.wordcamp.org/schedule/',
+                __( 'WordCamps' ),
+                /* translators: accessibility text */
+                __( '(opens in a new window)' )
+            );
+        ?>
 
         |
 
-        <?php // translators: If a Rosetta site exists (e.g. https://es.wordpress.org/news/), then use that. Otherwise, leave untranslated. ?>
-        <a href="<?php _e( 'https://wordpress.org/news/' ); ?>" target="_blank">
-            <?php _e( 'News' ); ?> <span class="dashicons dashicons-external"></span>
-        </a>
+        <?php
+            printf(
+                '<a href="%1$s" target="_blank">%2$s <span class="screen-reader-text">%3$s</span><span aria-hidden="true" class="dashicons dashicons-external"></span></a>',
+                /* translators: If a Rosetta site exists (e.g. https://es.wordpress.org/news/), then use that. Otherwise, leave untranslated. */
+                esc_url( __( 'https://wordpress.org/news/' ) ),
+                __( 'News' ),
+                /* translators: accessibility text */
+                __( '(opens in a new window)' )
+            );
+        ?>
     </p>
 

trunk/src/wp-admin/includes/meta-boxes.php

@@ -59 +59 @@
     $preview_button_text,
     /* translators: accessibility text */
-    __( '(link opens in a new window)' )
+    __( '(opens in a new window)' )
 );
 ?>

trunk/src/wp-includes/class-wp-customize-manager.php

@@ -4145 +4145 @@
                 esc_url( __( 'https://codex.wordpress.org/CSS' ) ),
                 __( 'Learn more about CSS' ),
-                __( '(link opens in a new window)' )
+                /* translators: accessibility text */
+                __( '(opens in a new window)' )
             ),
         ) );