Changeset 40657

Timestamp:

05/12/2017 08:05:07 PM (8 years ago)

Author:

adamsilverstein

Message:

Users: Update name in toolbar when changing user display name.

When changing the user name in Users -> Your Profile, update the name displayed in the toolbar dynamically using JavaScript.

Props menakas, lukecavanagh, maguiar.
Fixes #40342.

Location:

trunk/src

Files:

• wp-admin/js/user-profile.js (modified) (2 diffs)
• wp-includes/admin-bar.php (modified) (1 diff)

trunk/src/wp-admin/js/user-profile.js

@@ -329 +329 @@
     $(document).ready( function() {
         var $colorpicker, $stylesheet, user_id, current_user_id,
-            select = $( '#display_name' );
+            select       = $( '#display_name' ),
+            current_name = select.val(),
+            greeting     = $( '#wp-admin-bar-my-account' ).find( '.display-name' );
 
         $('#pass1').val('').on( inputEvent + ' pwupdate', check_pass_strength );
@@ -371 +373 @@
                 });
             });
+
+            /**
+             * Replaces "Howdy, *" in the admin toolbar whenever the display name dropdown is updated for one's own profile.
+             */
+            select.on( 'change', function() {
+                if ( user_id !== current_user_id ) {
+                    return;
+                }
+
+                var display_name = $.trim( this.value ) || current_name;
+
+                greeting.text( display_name );
+            } );
         }
 

trunk/src/wp-includes/admin-bar.php

@@ -215 +215 @@
     $avatar = get_avatar( $user_id, 26 );
     /* translators: %s: current user's display name */
-    $howdy  = sprintf( __( 'Howdy, %s' ), $current_user->display_name );
+    $howdy  = sprintf( __( 'Howdy, %s' ), '<span class="display-name">' . $current_user->display_name . '</span>' );
     $class  = empty( $avatar ) ? '' : 'with-avatar';