Changeset 40772

Timestamp:

05/17/2017 01:58:16 AM (7 years ago)

Author:

westonruter

Message:

Media: Trim whitespace in URLs provided for external embeds.

Also avoid showing error notice in media widget when URL field is empty.

Props timmydcrawford, westonruter.
Fixes #40771.

Location:

trunk/src

Files:

• wp-admin/js/widgets/media-widgets.js (modified) (2 diffs)
• wp-includes/js/media-views.js (modified) (1 diff)
• wp-includes/js/media/views/embed/url.js (modified) (1 diff)

trunk/src/wp-admin/js/widgets/media-widgets.js

@@ -143 +143 @@
                      * Fetch media.
                      *
-                     * This is a TEMPORARY measure until the WP API supports an oEmbed proxy endpoint. See #40450.
-                     *
-                     * @see https://core.trac.wordpress.org/ticket/40450
                      * @returns {void}
                      */
@@ -153 +150 @@
                         if ( embedLinkView.dfd && 'pending' === embedLinkView.dfd.state() ) {
                             embedLinkView.dfd.abort();
+                        }
+
+                        // Abort if the URL field was emptied out.
+                        if ( ! embedLinkView.model.get( 'url' ) ) {
+                            embedLinkView.setErrorNotice( '' );
+                            return;
                         }
 

trunk/src/wp-includes/js/media-views.js

@@ -4740 +4740 @@
 
     url: function( event ) {
-        this.model.set( 'url', event.target.value );
+        this.model.set( 'url', $.trim( event.target.value ) );
     },
 

trunk/src/wp-includes/js/media/views/embed/url.js

@@ -61 +61 @@
 
     url: function( event ) {
-        this.model.set( 'url', event.target.value );
+        this.model.set( 'url', $.trim( event.target.value ) );
     },