Changeset 40800

Timestamp:

05/19/2017 06:28:58 PM (8 years ago)

Author:

joemcgill

Message:

Media: Ensure WP_Screen sets post type on wp-admin/upload.php.

The post type property is set to 'attachment' when on the upload screen.

Props postpostmodern.
Fixes #39509.

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-screen.php (modified) (1 diff)
• tests/phpunit/tests/admin/includesScreen.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-screen.php

@@ -308 +308 @@
                     if ( null === $post_type && is_object_in_taxonomy( 'post', $taxonomy ? $taxonomy : 'post_tag' ) )
                         $post_type = 'post';
+                    break;
+                case 'upload':
+                    $post_type = 'attachment';
                     break;
             }

trunk/tests/phpunit/tests/admin/includesScreen.php

@@ -13 +13 @@
         'edit-tags.php?taxonomy=post_tag' => array( 'base' => 'edit-tags', 'id' => 'edit-post_tag', 'post_type' => 'post', 'taxonomy' => 'post_tag' ),
         'edit-tags.php?taxonomy=category' => array( 'base' => 'edit-tags', 'id' => 'edit-category', 'post_type' => 'post', 'taxonomy' => 'category' ),
-        'upload.php' => array( 'base' => 'upload', 'id' => 'upload' ),
+        'upload.php' => array( 'base' => 'upload', 'id' => 'upload', 'post_type' => 'attachment' ),
         'media-new.php' => array( 'action' => 'add', 'base' => 'media', 'id' => 'media' ),
         'edit.php?post_type=page' => array( 'base' => 'edit', 'id' => 'edit-page', 'post_type' => 'page' ),