Changeset 40809 for trunk/src/wp-includes/media.php

Timestamp:

05/20/2017 02:23:00 AM (2 years ago)

Author:

mikeschroder

Message:

Media: Decode HTML entities in author_name before sending to JS.

In wp_prepare_attachment_for_js():

• Normalize behavior when author does not exist by returning '(no author)' for authorName in these cases.
• Decode HTML entities in author_name.
• Add tests for both of the above.

Props arshidkv12, ocean90, sloisel, mikeschroder.
Fixes #39955.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -3099 +3099 @@
 
     $author = new WP_User( $attachment->post_author );
-    $response['authorName'] = $author->display_name;
+    if ( $author->exists() ) {
+        $response['authorName'] = html_entity_decode( $author->display_name, ENT_QUOTES, get_bloginfo( 'charset' ) );
+    } else {
+        $response['authorName'] = __( '(no author)' );
+    }
 
     if ( $attachment->post_parent ) {