Changeset 40809 for trunk/tests/phpunit/tests/media.php

Timestamp:

05/20/2017 02:23:00 AM (2 years ago)

Author:

mikeschroder

Message:

Media: Decode HTML entities in author_name before sending to JS.

In wp_prepare_attachment_for_js():

• Normalize behavior when author does not exist by returning '(no author)' for authorName in these cases.
• Decode HTML entities in author_name.
• Add tests for both of the above.

Props arshidkv12, ocean90, sloisel, mikeschroder.
Fixes #39955.

File:

• trunk/tests/phpunit/tests/media.php (modified) (1 diff)

trunk/tests/phpunit/tests/media.php

@@ -268 +268 @@
         $this->assertEquals( 'image', $prepped['type'] );
         $this->assertEquals( '', $prepped['subtype'] );
+
+        // Test that if author is not found, we return "(no author)" as `display_name`.
+        // The previously used test post contains no author, so we can reuse it.
+        $this->assertEquals( '(no author)', $prepped['authorName'] );
+
+        // Test that if author has HTML entities in display_name, they're decoded correctly.
+        $html_entity_author = self::factory()->user->create( array(
+            'display_name' => 'You & Me',
+        ) );
+        $post->post_author = $html_entity_author;
+        $prepped = wp_prepare_attachment_for_js( $post );
+        $this->assertEquals( 'You & Me', $prepped['authorName'] );
     }