Changeset 40815 for trunk/src/wp-includes/rest-api/class-wp-rest-request.php

Timestamp:

05/22/2017 04:15:25 PM (8 years ago)

Author:

jnylen0

Message:

REST API: Fix changing parameters with set_param() for some requests.

Prior to this commit, WP_Rest_Request::get_param() traversed through the parameter order but WP_Rest_Request::set_param() did not. For JSON requests (and likely other situations as well), this meant that changing a parameter with set_param() would have no effect on get_param().

Props TimothyBlynJacobs.
Fixes #40344.

File:

• trunk/src/wp-includes/rest-api/class-wp-rest-request.php (modified) (2 diffs)

trunk/src/wp-includes/rest-api/class-wp-rest-request.php

@@ -355 +355 @@
     protected function get_parameter_order() {
         $order = array();
-        $order[] = 'JSON';
+
+        $content_type = $this->get_content_type();
+        if ( $content_type['value'] === 'application/json' ) {
+            $order[] = 'JSON';
+        }
 
         $this->parse_json_params();
@@ -425 +429 @@
      */
     public function set_param( $key, $value ) {
-        switch ( $this->method ) {
-            case 'POST':
-                $this->params['POST'][ $key ] = $value;
-                break;
-
-            default:
-                $this->params['GET'][ $key ] = $value;
-                break;
-        }
+        $order = $this->get_parameter_order();
+        $this->params[ $order[0] ][ $key ] = $value;
     }