Changeset 40816 for trunk/tests/phpunit/tests/term/wpGenerateTagCloud.php

Timestamp:

05/22/2017 08:23:49 PM (7 years ago)

Author:

afercia

Message:

Widgets: Remove the title attributes used in the Tag cloud widget.

• improves accessibility using an aria-label attribute to match the information conveyed visually with the one exposed to assistive technologies
• adds an option in the widget to display the item counts, consistently with what other widgets already do (Archives, Categories)

Props adamsoucie, emirpprime, Samantha Miller., MikeLittle, rianrietveld, sami.keijonen, adamsilverstein, westonruter, afercia.
See #24766.
Fixes #35566.

File:

• trunk/tests/phpunit/tests/term/wpGenerateTagCloud.php (modified) (4 diffs)

trunk/tests/phpunit/tests/term/wpGenerateTagCloud.php

@@ -120 +120 @@
         ) );
 
-        $this->assertRegExp( "|^<ul class='wp-tag-cloud'>|", $found );
+        $this->assertRegExp( "|^<ul class='wp-tag-cloud' role='list'>|", $found );
         $this->assertRegExp( "|</ul>\n|", $found );
         $this->assertContains( '>' . $tags[0]->name . '<', $found );
@@ -165 +165 @@
         ) );
 
-        $this->assertRegExp( "|^<ul class='wp-tag-cloud'>|", $found );
+        $this->assertRegExp( "|^<ul class='wp-tag-cloud' role='list'>|", $found );
         $this->assertRegExp( "|</ul>\n|", $found );
 
@@ -199 +199 @@
         ) );
 
-        $this->assertContains( "title='Term has 1 post'", $actual[0] );
-        $this->assertContains( "title='Term has 2 posts'", $actual[1] );
+        $this->assertContains( 'aria-label="' . $term_objects[0]->name . ' (Term has 1 post)"', $actual[0] );
+        $this->assertContains( 'aria-label="' . $term_objects[1]->name . ' (Term has 2 posts)"', $actual[1] );
     }
 
@@ -224 +224 @@
         ) );
 
-        $this->assertContains( "title='1 foo'", $actual[0] );
-        $this->assertContains( "title='2 foo'", $actual[1] );
+        $this->assertContains( 'aria-label="' . $term_objects[0]->name . ' (1 foo)"', $actual[0] );
+        $this->assertContains( 'aria-label="' . $term_objects[1]->name . ' (2 foo)"', $actual[1] );
     }