Changeset 40823

Timestamp:

05/23/2017 05:57:42 PM (9 years ago)

Author:

afercia

Message:

Administration: Fix some HTML validation errors.

Fixes some minor HTML issues in the admin and, most notably, changes the rel
attribute used in the List Tables from rel="permalink" to rel="bookmark".

Props mihai2u, pento, arena, topher1kenobe, michalzuber, stubgo.
Fixes #37004.

Location:

trunk/src/wp-admin

Files:

• css/forms.css (modified) (1 diff)
• includes/class-wp-media-list-table.php (modified) (2 diffs)
• includes/class-wp-ms-sites-list-table.php (modified) (1 diff)
• includes/class-wp-posts-list-table.php (modified) (2 diffs)
• includes/class-wp-users-list-table.php (modified) (3 diffs)
• includes/template.php (modified) (1 diff)
• options-general.php (modified) (3 diffs)
• options-media.php (modified) (1 diff)

trunk/src/wp-admin/css/forms.css

@@ -651 +651 @@
 }
 
-.form-table th.th-full {
+.form-table th.th-full, /* Not used by core. Back-compat for pre-4.8 */
+.form-table .td-full {
         width: auto;
+        padding: 20px 10px 20px 0;
         font-weight: 400;
 }

trunk/src/wp-admin/includes/class-wp-media-list-table.php

@@ -679 +679 @@
                         }
                         $actions['view'] = sprintf(
-                                '<a href="%s" aria-label="%s" rel="permalink">%s</a>',
+                                '<a href="%s" aria-label="%s" rel="bookmark">%s</a>',
                                 get_permalink( $post->ID ),
                                 /* translators: %s: attachment title */
@@ -738 +738 @@
                         if ( ! $this->is_trash ) {
                                 $actions['view'] = sprintf(
-                                        '<a href="%s" aria-label="%s" rel="permalink">%s</a>',
+                                        '<a href="%s" aria-label="%s" rel="bookmark">%s</a>',
                                         get_permalink( $post->ID ),
                                         /* translators: %s: attachment title */

trunk/src/wp-admin/includes/class-wp-ms-sites-list-table.php

@@ -550 +550 @@
                 }
 
-                $actions['visit']       = "<a href='" . esc_url( get_home_url( $blog['blog_id'], '/' ) ) . "' rel='permalink'>" . __( 'Visit' ) . '</a>';
+                $actions['visit']       = "<a href='" . esc_url( get_home_url( $blog['blog_id'], '/' ) ) . "' rel='bookmark'>" . __( 'Visit' ) . '</a>';
 
                 /**

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1289 +1289 @@
                                         $preview_link = get_preview_post_link( $post );
                                         $actions['view'] = sprintf(
-                                                '<a href="%s" rel="permalink" aria-label="%s">%s</a>',
+                                                '<a href="%s" rel="bookmark" aria-label="%s">%s</a>',
                                                 esc_url( $preview_link ),
                                                 /* translators: %s: post title */
@@ -1298 +1298 @@
                         } elseif ( 'trash' != $post->post_status ) {
                                 $actions['view'] = sprintf(
-                                        '<a href="%s" rel="permalink" aria-label="%s">%s</a>',
+                                        '<a href="%s" rel="bookmark" aria-label="%s">%s</a>',
                                         get_permalink( $post->ID ),
                                         /* translators: %s: post title */

trunk/src/wp-admin/includes/class-wp-users-list-table.php

@@ -259 +259 @@
         protected function extra_tablenav( $which ) {
                 $id = 'bottom' === $which ? 'new_role2' : 'new_role';
+                $button_id = 'bottom' === $which ? 'changeit2' : 'changeit';
         ?>
         <div class="alignleft actions">
@@ -268 +269 @@
                 </select>
         <?php
-                        submit_button( __( 'Change' ), '', 'changeit', false );
+                        submit_button( __( 'Change' ), '', $button_id, false );
                 endif;
 
@@ -296 +297 @@
          */
         public function current_action() {
-                if ( isset( $_REQUEST['changeit'] ) &&
+                if ( ( isset( $_REQUEST['changeit'] ) || isset( $_REQUEST['changeit2'] ) ) &&
                         ( ! empty( $_REQUEST['new_role'] ) || ! empty( $_REQUEST['new_role2'] ) ) ) {
                         return 'promote';

trunk/src/wp-admin/includes/template.php

@@ -1521 +1521 @@
                 <div id="find-posts-head" class="find-box-head">
                         <?php _e( 'Attach to existing content' ); ?>
-                        <button type="button" id="find-posts-close"><span class="screen-reader-text"><?php _e( 'Close media attachment panel' ); ?></button>
+                        <button type="button" id="find-posts-close"><span class="screen-reader-text"><?php _e( 'Close media attachment panel' ); ?></span></button>
                 </div>
                 <div class="find-box-inside">

trunk/src/wp-admin/options-general.php

@@ -131 +131 @@
         ?>
         <tr>
-                <th width="33%" scope="row"><label for="WPLANG"><?php _e( 'Site Language' ); ?></label></th>
+                <th scope="row"><label for="WPLANG"><?php _e( 'Site Language' ); ?></label></th>
                 <td>
                         <?php
@@ -298 +298 @@
         echo '<label><input type="radio" name="date_format" id="date_format_custom_radio" value="\c\u\s\t\o\m"';
         checked( $custom );
-        echo '/> <span class="date-time-text date-time-custom-text">' . __( 'Custom:' ) . '<span class="screen-reader-text"> ' . __( 'enter a custom date format in the following field' ) . '</span></label>' .
+        echo '/> <span class="date-time-text date-time-custom-text">' . __( 'Custom:' ) . '<span class="screen-reader-text"> ' . __( 'enter a custom date format in the following field' ) . '</span></span></label>' .
                 '<label for="date_format_custom" class="screen-reader-text">' . __( 'Custom date format:' ) . '</label>' .
-                '<input type="text" name="date_format_custom" id="date_format_custom" value="' . esc_attr( get_option( 'date_format' ) ) . '" class="small-text" /></span>' .
+                '<input type="text" name="date_format_custom" id="date_format_custom" value="' . esc_attr( get_option( 'date_format' ) ) . '" class="small-text" />' .
                 '<span class="screen-reader-text">' . __( 'example:' ) . ' </span> <span class="example">' . date_i18n( get_option( 'date_format' ) ) . '</span>' .
                 "<span class='spinner'></span>\n";
@@ -334 +334 @@
         echo '<label><input type="radio" name="time_format" id="time_format_custom_radio" value="\c\u\s\t\o\m"';
         checked( $custom );
-        echo '/> <span class="date-time-text date-time-custom-text">' . __( 'Custom:' ) . '<span class="screen-reader-text"> ' . __( 'enter a custom time format in the following field' ) . '</span></label>' .
+        echo '/> <span class="date-time-text date-time-custom-text">' . __( 'Custom:' ) . '<span class="screen-reader-text"> ' . __( 'enter a custom time format in the following field' ) . '</span></span></label>' .
                 '<label for="time_format_custom" class="screen-reader-text">' . __( 'Custom time format:' ) . '</label>' .
-                '<input type="text" name="time_format_custom" id="time_format_custom" value="' . esc_attr( get_option( 'time_format' ) ) . '" class="small-text" /></span>' .
+                '<input type="text" name="time_format_custom" id="time_format_custom" value="' . esc_attr( get_option( 'time_format' ) ) . '" class="small-text" />' .
                 '<span class="screen-reader-text">' . __( 'example:' ) . ' </span> <span class="example">' . date_i18n( get_option( 'time_format' ) ) . '</span>' .
                 "<span class='spinner'></span>\n";

trunk/src/wp-admin/options-media.php

@@ -119 +119 @@
 </td>
 </tr>
+<tr>
+<td colspan="2" class="td-full">
+<?php else : ?>
+<tr>
+<td class="td-full">
 <?php endif; ?>
-<tr>
-<th scope="row" colspan="2" class="th-full">
 <label for="uploads_use_yearmonth_folders">
 <input name="uploads_use_yearmonth_folders" type="checkbox" id="uploads_use_yearmonth_folders" value="1"<?php checked('1', get_option('uploads_use_yearmonth_folders')); ?> />
 <?php _e('Organize my uploads into month- and year-based folders'); ?>
 </label>
-</th>
+</td>
 </tr>