Changeset 40892 for trunk/src/wp-includes/media.php

Timestamp:

06/09/2017 07:28:12 PM (7 years ago)

Author:

westonruter

Message:

Media: Restrict appending loop parameter to Vimeo URLs specifically and not all external URLs in Video widget (via shortcode).

Fixes issue where Video widgets embedding external files fail to get recognized due to the presence of the loop param after the video filename, even though it has a recognized extension. Regardless, the loop param is only present to fix a Vimeo issue in ME.js 2.x.

Props timmydcrawford.
Amends [40640].
See #39686, #39994.
Fixes #40977.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -2557 +2557 @@
             // Remove all query arguments and force SSL - see #40866.
             $parsed_vimeo_url = wp_parse_url( $atts['src'] );
-            $atts['src'] = 'https://' . $parsed_vimeo_url['host'] . $parsed_vimeo_url['path'];
+            $vimeo_src = 'https://' . $parsed_vimeo_url['host'] . $parsed_vimeo_url['path'];
+
+            // Add loop param for mejs bug - see #40977, not needed after #39686.
+            $loop = $atts['loop'] ? '1' : '0';
+            $atts['src'] = add_query_arg( 'loop', $loop, $vimeo_src );
         }
     }