Changeset 41001

Timestamp:

07/05/2017 12:43:11 AM (8 years ago)

Author:

westonruter

Message:

Customize: Fix logic to re-expand a newly inserted nav menu section after placeholder section is replaced.

Fixes todo from Menu Customizer feature plugin: ​https://github.com/voldemortensen/menu-customizer/commit/0f4ea4e#diff-daa55fade2253f26ccbe02f71058841cR2330
Amends [32806].
Props greuben.
See #32576.
Fixes #40997.

File:

• trunk/src/wp-admin/js/customize-nav-menus.js (modified) (3 diffs)

trunk/src/wp-admin/js/customize-nav-menus.js

@@ -2853 +2853 @@
 
         _( data.nav_menu_updates ).each(function( update ) {
-            var oldCustomizeId, newCustomizeId, customizeId, oldSetting, newSetting, setting, settingValue, oldSection, newSection, wasSaved, widgetTemplate, navMenuCount;
+            var oldCustomizeId, newCustomizeId, customizeId, oldSetting, newSetting, setting, settingValue, oldSection, newSection, wasSaved, widgetTemplate, navMenuCount, shouldExpandNewSection;
             if ( 'inserted' === update.status ) {
                 if ( ! update.previous_term_id ) {
@@ -2885 +2885 @@
                 } );
 
-                if ( oldSection.expanded() ) {
+                shouldExpandNewSection = oldSection.expanded();
+                if ( shouldExpandNewSection ) {
                     oldSection.collapse();
                 }
@@ -2960 +2961 @@
                 } );
 
-                if ( oldSection.expanded.get() ) {
-                    // @todo This doesn't seem to be working.
+                if ( shouldExpandNewSection ) {
                     newSection.expand();
                 }