Changeset 41009

Timestamp:

07/06/2017 12:40:59 AM (9 years ago)

Author:

joemcgill

Message:

Sanity check $uploaderToggler in wp.media.view.UploaderInline.

This ensures $uploaderToggler exists before checking length so any views
extending or scripts accessing this view, won't encounter errors that stop execution.

Props Blackbam, yahil.
Fixes #41231.

Location:

trunk/src/wp-includes/js

Files:

• media-views.js (modified) (2 diffs)
• media/views/uploader/inline.js (modified) (2 diffs)

trunk/src/wp-includes/js/media-views.js

@@ -8229 +8229 @@
         show: function() {
                 this.$el.removeClass( 'hidden' );
-                if ( this.controller.$uploaderToggler.length ) {
+                if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) {
                         this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' );
                 }
@@ -8235 +8235 @@
         hide: function() {
                 this.$el.addClass( 'hidden' );
-                if ( this.controller.$uploaderToggler.length ) {
+                if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) {
                         this.controller.$uploaderToggler
                                 .attr( 'aria-expanded', 'false' )

trunk/src/wp-includes/js/media/views/uploader/inline.js

@@ -120 +120 @@
         show: function() {
                 this.$el.removeClass( 'hidden' );
-                if ( this.controller.$uploaderToggler.length ) {
+                if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) {
                         this.controller.$uploaderToggler.attr( 'aria-expanded', 'true' );
                 }
@@ -126 +126 @@
         hide: function() {
                 this.$el.addClass( 'hidden' );
-                if ( this.controller.$uploaderToggler.length ) {
+                if ( this.controller.$uploaderToggler && this.controller.$uploaderToggler.length ) {
                         this.controller.$uploaderToggler
                                 .attr( 'aria-expanded', 'false' )