Changeset 41023 for branches/4.8/src/wp-admin/includes/class-wp-comments-list-table.php

Timestamp:

07/10/2017 11:08:35 PM (9 years ago)

Author:

SergeyBiryukov

Message:

Comments: In WP_Comments_List_Table::extra_tablenav(), save the state of ::has_items() to a static variable, so that the value is consistent between top and bottom navigation.

This prevents "Empty Spam" and "Empty Trash" buttons from disappearing if there's only one page of comments in Spam/Trash.

Fixes #40975.

Merges [41022] to the 4.8 branch.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/class-wp-comments-list-table.php (modified) (2 diffs)

branches/4.8/src/wp-admin/includes/class-wp-comments-list-table.php

@@ -320 +320 @@
         protected function extra_tablenav( $which ) {
                 global $comment_status, $comment_type;
+                static $has_items;
+
+                if ( ! isset( $has_items ) ) {
+                        $has_items = $this->has_items();
+                }
 ?>
                 <div class="alignleft actions">
@@ -355 +360 @@
                 }
 
-                if ( ( 'spam' === $comment_status || 'trash' === $comment_status ) && current_user_can( 'moderate_comments' ) && $this->has_items() ) {
+                if ( ( 'spam' === $comment_status || 'trash' === $comment_status ) && current_user_can( 'moderate_comments' ) && $has_items ) {
                         wp_nonce_field( 'bulk-destroy', '_destroy_nonce' );
                         $title = ( 'spam' === $comment_status ) ? esc_attr__( 'Empty Spam' ) : esc_attr__( 'Empty Trash' );