Changeset 41024

Timestamp:

07/10/2017 11:15:28 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Accessibility: Avoid a keyboard trap on the permalink custom structure setting.

Using the focus event on the permalink custom structure field made impossible
to navigate through all the form fields using only the keyboard without actually
selecting the custom structure setting. Instead, using click and input preserves
the original functionality when using any kind of pointing or input device.

Also changes attr() to prop() as recommended for a checked property.

Props afercia.
Fixes #40982.

Merges [40897] to the 4.8 branch.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• src/wp-admin/includes/options.php (modified) (1 diff)

branches/4.8/src/wp-admin/includes/options.php

@@ -101 +101 @@
         jQuery('#permalink_structure').val( this.value );
     });
-    jQuery('#permalink_structure').focus(function() {
-        jQuery("#custom_selection").attr('checked', 'checked');
+    jQuery( '#permalink_structure' ).on( 'click input', function() {
+        jQuery( '#custom_selection' ).prop( 'checked', true );
     });
 });