Changeset 41038 for branches/4.8/src/wp-includes/taxonomy.php

Timestamp:

07/13/2017 01:42:44 PM (7 years ago)

Author:

boonebgorges

Message:

Taxonomy: Avoid duplicates when querying for terms in taxonomies registered with $args parameter.

[40514] introduced a bug that caused term queries to return some duplicates
when the $taxonomies array contained only taxonomies that were originally
registered with an $args array. We fix this bug by ensuring that
recursive get_terms() queries stop when all queried $taxonomies have
already been referenced.

Ports [41037] to the 4.8 branch.

Props bor0, atanasangelovdev.
Fixes #41010.

Location:

branches/4.8

Files:

• . (modified) (1 prop)
• src/wp-includes/taxonomy.php (modified) (1 diff)

branches/4.8/src/wp-includes/taxonomy.php

@@ -1865 +1865 @@
     $args['object_ids'] = $object_ids;
 
-    $terms = array_merge( $terms, get_terms( $args ) );
+    // Taxonomies registered without an 'args' param are handled here.
+    if ( ! empty( $taxonomies ) ) {
+        $terms = array_merge( $terms, get_terms( $args ) );
+    }
 
     /**