Changeset 41059 for trunk/src/wp-includes/class-wp-site-query.php

Timestamp:

07/14/2017 09:24:03 PM (7 years ago)

Author:

flixos90

Message:

Multisite: Improve caching in WP_Site_Query by ignoring the $fields argument.

Prior to this change there were two different cache keys used for the same query. That is because regardless of the $fields argument, the query response will be the same.

Props spacedmonkey.
Fixes #41197.

File:

• trunk/src/wp-includes/class-wp-site-query.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-site-query.php

@@ -252 +252 @@
 
         // $args can include anything. Only use the args defined in the query_var_defaults to compute the key.
-        $key = md5( serialize( wp_array_slice_assoc( $this->query_vars, array_keys( $this->query_var_defaults ) ) ) );
+        $_args = wp_array_slice_assoc( $this->query_vars, array_keys( $this->query_var_defaults ) );
+
+        // Ignore the $fields argument as the queried result will be the same regardless.
+        unset( $_args['fields'] );
+
+        $key = md5( serialize( $_args ) );
         $last_changed = wp_cache_get_last_changed( 'sites' );