Changeset 41205 for trunk/src/wp-includes/class-wp-customize-nav-menus.php

Timestamp:

08/02/2017 05:34:32 AM (9 years ago)

Author:

westonruter

Message:

Customize: Introduce settings_previewed arg and getter on WP_Customize_Manager which controls whether WP_Customize_Setting::preview() should be called on settings.

The settings_previewed property eliminates the need for the Customizer components from having to look at global doing_ajax state. This is in particular needed when saving settings, as some settings will short-circuit the update operation if they detect no changes are introduced. This is also needed for low-level integrations with the Customizer, such as in REST API endpoints under development.

Props stubgo, westonruter, utkarshpatel for testing.
See #38900.
Fixes #39221.

File:

• trunk/src/wp-includes/class-wp-customize-nav-menus.php (modified) (1 diff)

trunk/src/wp-includes/class-wp-customize-nav-menus.php

@@ -527 +527 @@
                         }
                 }
-                $this->manager->add_dynamic_settings( $nav_menus_setting_ids );
-                if ( ! $this->manager->doing_ajax( 'customize_save' ) ) {
-                        foreach ( $nav_menus_setting_ids as $setting_id ) {
-                                $setting = $this->manager->get_setting( $setting_id );
-                                if ( $setting ) {
-                                        $setting->preview();
-                                }
+                $settings = $this->manager->add_dynamic_settings( $nav_menus_setting_ids );
+                if ( $this->manager->settings_previewed() ) {
+                        foreach ( $settings as $setting ) {
+                                $setting->preview();
                         }
                 }