Changeset 41219

Timestamp:

08/03/2017 03:42:45 PM (9 years ago)

Author:

johnbillion

Message:

General: Fix various instances of incorrect filter docs and incorrect filter and action parameters.

Props keesiemeijer for identifying the issues

See #38462

Location:

trunk

Files:

• src/wp-admin/includes/class-wp-ms-themes-list-table.php (modified) (2 diffs)
• src/wp-admin/includes/class-wp-posts-list-table.php (modified) (1 diff)
• src/wp-admin/includes/class-wp-press-this.php (modified) (1 diff)
• src/wp-admin/includes/class-wp-themes-list-table.php (modified) (1 diff)
• src/wp-admin/includes/ms.php (modified) (1 diff)
• src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php (modified) (1 diff)
• src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php (modified) (1 diff)
• src/wp-includes/theme.php (modified) (1 diff)
• tests/phpunit/tests/rest-api/rest-revisions-controller.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-ms-themes-list-table.php

@@ -480 +480 @@
                  * @param array    $actions An array of action links.
                  * @param WP_Theme $theme   The current WP_Theme object.
-                 * @param string   $context Status of the theme.
+                 * @param string   $context Status of the theme, one of all', 'enabled', or 'disabled'.
                  */
                 $actions = apply_filters( 'theme_action_links', array_filter( $actions ), $theme, $context );
@@ -496 +496 @@
                  * @param array    $actions An array of action links.
                  * @param WP_Theme $theme   The current WP_Theme object.
-                 * @param string   $context Status of the theme.
+                 * @param string   $context Status of the theme, one of all', 'enabled', or 'disabled'.
                  */
                 $actions = apply_filters( "theme_action_links_{$stylesheet}", $actions, $theme, $context );

trunk/src/wp-admin/includes/class-wp-posts-list-table.php

@@ -1721 +1721 @@
                                  *
                                  * @param string $column_name Name of the column to edit.
-                                 * @param string $post_type   The post type slug.
+                                 * @param string $post_type   The post type slug, or current screen name if this is a taxonomy list table.
+                                 * @param string taxonomy     The taxonomy name, if any.
                                  */
-                                do_action( 'quick_edit_custom_box', $column_name, $screen->post_type );
+                                do_action( 'quick_edit_custom_box', $column_name, $screen->post_type, '' );
                         }
 

trunk/src/wp-admin/includes/class-wp-press-this.php

@@ -1523 +1523 @@
         <?php
         /** This action is documented in wp-admin/admin-footer.php */
-        do_action( 'admin_footer' );
+        do_action( 'admin_footer', '' );
 
         /** This action is documented in wp-admin/admin-footer.php */

trunk/src/wp-admin/includes/class-wp-themes-list-table.php

@@ -193 +193 @@
 
                         /** This filter is documented in wp-admin/includes/class-wp-ms-themes-list-table.php */
-                        $actions       = apply_filters( 'theme_action_links', $actions, $theme );
+                        $actions       = apply_filters( 'theme_action_links', $actions, $theme, 'all' );
 
                         /** This filter is documented in wp-admin/includes/class-wp-ms-themes-list-table.php */
-                        $actions       = apply_filters( "theme_action_links_$stylesheet", $actions, $theme );
+                        $actions       = apply_filters( "theme_action_links_$stylesheet", $actions, $theme, 'all' );
                         $delete_action = isset( $actions['delete'] ) ? '<div class="delete-theme">' . $actions['delete'] . '</div>' : '';
                         unset( $actions['delete'] );

trunk/src/wp-admin/includes/ms.php

@@ -261 +261 @@
 
         /** This action is documented in wp-admin/includes/user.php */
-        do_action( 'deleted_user', $id );
+        do_action( 'deleted_user', $id, null );
 
         return true;

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-posts-controller.php

@@ -1383 +1383 @@
                         $data['guid'] = array(
                                 /** This filter is documented in wp-includes/post-template.php */
-                                'rendered' => apply_filters( 'get_the_guid', $post->guid ),
+                                'rendered' => apply_filters( 'get_the_guid', $post->guid, $post->ID ),
                                 'raw'      => $post->guid,
                         );

trunk/src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-controller.php

@@ -370 +370 @@
                         $data['guid'] = array(
                                 /** This filter is documented in wp-includes/post-template.php */
-                                'rendered' => apply_filters( 'get_the_guid', $post->guid ),
+                                'rendered' => apply_filters( 'get_the_guid', $post->guid, $post->ID ),
                                 'raw'      => $post->guid,
                         );

trunk/src/wp-includes/theme.php

@@ -2750 +2750 @@
                 } else {
                         /** This action is documented in wp-includes/theme.php */
-                        do_action( 'after_switch_theme', $stylesheet );
+                        do_action( 'after_switch_theme', $stylesheet, $old_theme );
                 }
                 flush_rewrite_rules();

trunk/tests/phpunit/tests/rest-api/rest-revisions-controller.php

@@ -318 +318 @@
                 $this->assertEquals( $rendered_excerpt, $response['excerpt']['rendered'] );
 
-                $rendered_guid = apply_filters( 'get_the_guid', $revision->guid );
+                $rendered_guid = apply_filters( 'get_the_guid', $revision->guid, $revision->ID );
                 $this->assertEquals( $rendered_guid, $response['guid']['rendered'] );