Changeset 41225 for trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

Timestamp:

08/03/2017 09:40:02 PM (7 years ago)

Author:

flixos90

Message:

Multisite: Introduce a can_add_user_to_blog filter to prevent adding a user to a site.

Under certain circumstances, it can be necessary that a user should not be added to a site, beyond the restrictions that WordPress core applies. With the new can_add_user_to_blog filter, plugin developers can run custom checks and return an error in case of a failure, that will prevent the user from being added.

The user-facing parts and the REST API route that interact with add_user_to_blog() have been adjusted accordingly to provide appropriate error feedback when a user could not be added to a site. Furthermore, two existing error feedback messages in the site admin's "New User" screen have been adjusted to properly show inside an error notice instead of a success notice.

Props jmdodd.
Fixes #41101.

File:

• trunk/tests/phpunit/tests/rest-api/rest-users-controller.php (modified) (1 diff)

trunk/tests/phpunit/tests/rest-api/rest-users-controller.php

@@ -1019 +1019 @@
 
         $this->assertFalse( $user_is_member );
+    }
+
+    /**
+     * @ticket 41101
+     * @group ms-required
+     */
+    public function test_create_new_network_user_with_add_user_to_blog_failure() {
+        $this->allow_user_to_manage_multisite();
+
+        $params = array(
+            'username' => 'testuser123',
+            'password' => 'testpassword',
+            'email'    => 'test@example.com',
+            'name'     => 'Test User 123',
+            'roles'    => array( 'editor' ),
+        );
+
+        add_filter( 'can_add_user_to_blog', '__return_false' );
+
+        $request = new WP_REST_Request( 'POST', '/wp/v2/users' );
+        $request->add_header( 'content-type', 'application/x-www-form-urlencoded' );
+        $request->set_body_params( $params );
+        $response = $this->server->dispatch( $request );
+        $this->assertErrorResponse( 'user_cannot_be_added', $response );
     }