Changeset 41248

Timestamp:

08/13/2017 06:10:11 AM (8 years ago)

Author:

westonruter

Message:

Customize: Prevent attachment deletions from silently failing in media modals opened for Media widgets.

Amends [40640].
See #32417.
Fixes #41609.

File:

• trunk/src/wp-admin/js/widgets/media-widgets.js (modified) (1 diff)

trunk/src/wp-admin/js/widgets/media-widgets.js

@@ -709 +709 @@
             });
 
-            // Disable syncing of attachment changes back to server. See <https://core.trac.wordpress.org/ticket/40403>.
+            // Disable syncing of attachment changes back to server (except for deletions). See <https://core.trac.wordpress.org/ticket/40403>.
             defaultSync = wp.media.model.Attachment.prototype.sync;
-            wp.media.model.Attachment.prototype.sync = function rejectedSync() {
-                return $.Deferred().rejectWith( this ).promise();
+            wp.media.model.Attachment.prototype.sync = function( method ) {
+                if ( 'delete' === method ) {
+                    return defaultSync.apply( this, arguments );
+                } else {
+                    return $.Deferred().rejectWith( this ).promise();
+                }
             };
             mediaFrame.on( 'close', function onClose() {