Changeset 41256

Timestamp:

08/16/2017 07:03:01 PM (7 years ago)

Author:

westonruter

Message:

Customize: Harden color control's logic for obtaining default value to prevent JS error when non-string default supplied.

Props andreagobetti, yonivh for testing.
Fixes #37174.

File:

• trunk/src/wp-includes/customize/class-wp-customize-color-control.php (modified) (1 diff)

trunk/src/wp-includes/customize/class-wp-customize-color-control.php

@@ -92 +92 @@
         <# var defaultValue = '#RRGGBB', defaultValueAttr = '',
             isHueSlider = data.mode === 'hue';
-
-        if ( data.defaultValue && ! isHueSlider ) {
+        if ( data.defaultValue && _.isString( data.defaultValue ) && ! isHueSlider ) {
             if ( '#' !== data.defaultValue.substring( 0, 1 ) ) {
                 defaultValue = '#' + data.defaultValue;