Changeset 41268 for trunk/src/wp-admin/options.php

Timestamp:

08/18/2017 06:30:28 PM (9 years ago)

Author:

flixos90

Message:

Role/Capability: Introduce capabilities dedicated to installing and updating language files.

The new meta capabilities are called install_languages and update_languages. Prior to this change, there were no proper capability checks applied. Instead only the filesystem and related constants were checked, and for actual permissions a rather vague fallback was used where a user needed to have at least one of the other updating capabilities. In addition to being generally more verbose, the new capabilities make it possible for example to allow a user to update languages, but nothing else. By default they fall back to the original way of how they were handled.

Props johnbillion, flixos90.
Fixes #39677.

File:

• trunk/src/wp-admin/options.php (modified) (1 diff)

trunk/src/wp-admin/options.php

@@ -178 +178 @@
 
                 // Handle translation install.
-                if ( ! empty( $_POST['WPLANG'] ) && ( ! is_multisite() || is_super_admin() ) ) { // @todo: Skip if already installed
+                if ( ! empty( $_POST['WPLANG'] ) && current_user_can( 'install_languages' ) ) {
                         require_once( ABSPATH . 'wp-admin/includes/translation-install.php' );
 
-                        if ( wp_can_install_language_pack() ) {
-                                $language = wp_download_language_pack( $_POST['WPLANG'] );
-                                if ( $language ) {
-                                        $_POST['WPLANG'] = $language;
-                                }
+                        $language = wp_download_language_pack( $_POST['WPLANG'] );
+                        if ( $language ) {
+                                $_POST['WPLANG'] = $language;
                         }
                 }