Changeset 41315

Timestamp:

08/25/2017 04:15:27 PM (6 years ago)

Author:

joemcgill

Message:

Media: Prime post caches in 'wp_make_content_images_responsive()'.

In [38296] we replaced get_post_meta() with wp_get_attachment_metadata()
so that attachment metadata could be consistently filtered. However, this
results in extra post queries which were previously avoided.

This uses _prime_post_caches() instead of update_meta_cache() to improve
post caching before looping through all images to retrieve attachment metadata.

Props dlh.
Fixes #40490.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -1336 +1336 @@
     if ( count( $attachment_ids ) > 1 ) {
         /*
-         * Warm object cache for use with 'get_post_meta()'.
-         *
-         * To avoid making a database call for each image, a single query
-         * warms the object cache with the meta information for all images.
+         * Warm the object cache with post and meta information for all found
+         * images to avoid making individual database calls.
          */
-        update_meta_cache( 'post', array_keys( $attachment_ids ) );
+        _prime_post_caches( array_keys( $attachment_ids ), false, true );
     }